nodePackages: add create-{react,react-native}-app; regenerate package set #38121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
force-pushed
the
package-create-react-native-app
branch
from
b6fc8fc
to
5562fdf
Compare
|
I rebased onto latest master to resolve the conflict, should be mergable again :) |
GrahamcOfBorg
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
labels
Ma27
force-pushed
the
package-create-react-native-app
branch
from
5562fdf
to
2d165b0
Compare
|
@svanderburg can you merge this pls? I don't think it's worth resolving conflicts all the time for this change ... |
GrahamcOfBorg
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
These packages are binary that need to be available to generate a project, therefore it's helpful to have them as packages that can be installed with
nix-env.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)