Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-bash-completions: 0.6.4 -> 0.6.5 #38118

Merged
merged 1 commit into from Mar 30, 2018
Merged

nix-bash-completions: 0.6.4 -> 0.6.5 #38118

merged 1 commit into from Mar 30, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Mar 30, 2018 •
edited

Motivation for this change

Some minor changes to go with the release of Nix 2.0, this should be backported to 18.03 (but not 17.09):

  • Always fall back to file completion if nothing else is available
  • Complete the new nix.conf options when using the old commands, like nix-shell
  • Complete channel: syntax when using the old commands, like nix-build channel:<tab>
  • Some other minor fixes
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pSub pSub merged commit 3f8b7a4 into NixOS:master Mar 30, 2018
@hedning
Copy link
Contributor Author

hedning commented Mar 30, 2018

Could someone cherry pick this to 18.03?

@pSub
Copy link
Member

pSub commented Mar 30, 2018

Done.

@hedning
Copy link
Contributor Author

hedning commented Mar 30, 2018

Thanks :)

@hedning hedning deleted the nix-bash-completions-0.6.5 branch March 1, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hedning @pSub @bjornfor @GrahamcOfBorg