gpx: init at 2.5.2 #37150

leo60228 · 2018-03-15T22:18:49Z

Motivation for this change

I added GPX, a tool to convert Gcode to x3g files.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
(N/A) Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
(N/A) Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

leo60228 · 2018-03-15T22:29:29Z

The error seems like a problem in master; GPX is a standard autotools package with no dependencies AFAIK.

jfrankenau · 2018-03-15T23:41:19Z

pkgs/top-level/all-packages.nix

-
+
+  gpx = callPackage ../applications/misc/gpx { };
+


Trailing whitespace here.

jfrankenau · 2018-03-15T23:41:50Z

pkgs/applications/misc/gpx/default.nix

+  name = "gpx-${version}";
+  version = "2.5.2";
+
+  buildInputs = [ autoreconfHook ];


Use nativeBuildInputs instead.

Sorry, I was following the example on the wiki.

Got a link to it, so we can fix it?

In https://nixos.wiki/wiki/Packaging_Software the code sample is fine, but the link to a file that I based gpx off of is pinned to a version of nixpkgs using buildInputs.

Checked, this still isn't fixed

jfrankenau · 2018-03-15T23:42:42Z

maintainers/maintainer-list.nix

+  leo60228 = {
+    github = "leo60228";
+    name = "leo60228";
+  };


According to the head of this file an email address is mandatory.

I misread it.

leo60228 · 2018-03-15T23:45:26Z

Is the new commit good?

jfrankenau · 2018-03-15T23:49:09Z

Looks good to me. Just squash those commits.

leo60228 · 2018-03-15T23:50:50Z

Should I force push?

jfrankenau · 2018-03-15T23:51:57Z

That is inevitable as squashing is destructive.

leo60228 · 2018-03-15T23:55:35Z

Done.

grahamc · 2018-03-16T02:05:27Z

@GrahamcOfBorg eval

ryantm · 2018-03-16T03:51:45Z

pkgs/applications/misc/gpx/default.nix

+    homepage = https://github.com/markwal/GPX/;
+    license = stdenv.lib.licenses.gpl2;
+    platforms = stdenv.lib.platforms.unix;
+    maintainers = stdenv.lib.maintainers.leo60228;


I think it's failing to evaluate because maintainers should be an array.

leo60228 · 2018-03-16T17:04:46Z

Checks are fixed @ryantm

ryantm · 2018-03-16T17:12:37Z

@GrahamcOfBorg build gpx

GrahamcOfBorg · 2018-03-16T17:13:09Z

Success on x86_64-linux (full log)

Attempted: gpx

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kvgfwq661w5x6ciszm69yi1g9srqydls-gpx-2.5.2
shrinking /nix/store/kvgfwq661w5x6ciszm69yi1g9srqydls-gpx-2.5.2/bin/gpx
shrinking /nix/store/kvgfwq661w5x6ciszm69yi1g9srqydls-gpx-2.5.2/bin/machines
shrinking /nix/store/kvgfwq661w5x6ciszm69yi1g9srqydls-gpx-2.5.2/bin/s3gdump
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/kvgfwq661w5x6ciszm69yi1g9srqydls-gpx-2.5.2/bin 
patching script interpreter paths in /nix/store/kvgfwq661w5x6ciszm69yi1g9srqydls-gpx-2.5.2
checking for references to /tmp/nix-build-gpx-2.5.2.drv-0 in /nix/store/kvgfwq661w5x6ciszm69yi1g9srqydls-gpx-2.5.2...
/nix/store/kvgfwq661w5x6ciszm69yi1g9srqydls-gpx-2.5.2

GrahamcOfBorg · 2018-03-16T17:13:22Z

Success on x86_64-darwin (full log)

Attempted: gpx

Partial log (click to expand)

make[2]: Entering directory '/private/tmp/nix-build-gpx-2.5.2.drv-0/source'
make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-gpx-2.5.2.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-gpx-2.5.2.drv-0/source'
post-installation fixup
strip is /nix/store/vb6mgjqgd9h11nbv60fvrp1ls9nxck2y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/6s00h8zdhz73szm77w4wpgqi622mj6ai-gpx-2.5.2/bin
patching script interpreter paths in /nix/store/6s00h8zdhz73szm77w4wpgqi622mj6ai-gpx-2.5.2
/nix/store/6s00h8zdhz73szm77w4wpgqi622mj6ai-gpx-2.5.2

GrahamcOfBorg · 2018-03-16T17:13:34Z

Success on aarch64-linux (full log)

Attempted: gpx

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3j4gk5k0s059a923myylj4rpfgp9gfcl-gpx-2.5.2
shrinking /nix/store/3j4gk5k0s059a923myylj4rpfgp9gfcl-gpx-2.5.2/bin/machines
shrinking /nix/store/3j4gk5k0s059a923myylj4rpfgp9gfcl-gpx-2.5.2/bin/s3gdump
shrinking /nix/store/3j4gk5k0s059a923myylj4rpfgp9gfcl-gpx-2.5.2/bin/gpx
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3j4gk5k0s059a923myylj4rpfgp9gfcl-gpx-2.5.2/bin
patching script interpreter paths in /nix/store/3j4gk5k0s059a923myylj4rpfgp9gfcl-gpx-2.5.2
checking for references to /build in /nix/store/3j4gk5k0s059a923myylj4rpfgp9gfcl-gpx-2.5.2...
/nix/store/3j4gk5k0s059a923myylj4rpfgp9gfcl-gpx-2.5.2

ryantm

LGTM

jfrankenau reviewed Mar 15, 2018

View reviewed changes

pkgs/top-level/all-packages.nix Outdated

gpx = callPackage ../applications/misc/gpx { };

Copy link

Member

jfrankenau Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace here.

jfrankenau reviewed Mar 15, 2018

View reviewed changes

ryantm reviewed Mar 16, 2018

View reviewed changes

gpx: init at 2.5.2

628f4e4

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 16, 2018

ryantm approved these changes Mar 16, 2018

View reviewed changes

globin merged commit 5de6ee2 into NixOS:master Mar 30, 2018

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gpx: init at 2.5.2 #37150

gpx: init at 2.5.2 #37150

leo60228 commented Mar 15, 2018 •

edited

leo60228 commented Mar 15, 2018

jfrankenau Mar 15, 2018

jfrankenau Mar 15, 2018

leo60228 Mar 15, 2018

jfrankenau Mar 15, 2018

leo60228 Mar 16, 2018

leo60228 May 10, 2018

jfrankenau Mar 15, 2018

leo60228 Mar 15, 2018

leo60228 commented Mar 15, 2018

jfrankenau commented Mar 15, 2018

leo60228 commented Mar 15, 2018

jfrankenau commented Mar 15, 2018

leo60228 commented Mar 15, 2018

grahamc commented Mar 16, 2018

ryantm Mar 16, 2018

leo60228 commented Mar 16, 2018

ryantm commented Mar 16, 2018

GrahamcOfBorg commented Mar 16, 2018

GrahamcOfBorg commented Mar 16, 2018

GrahamcOfBorg commented Mar 16, 2018

ryantm left a comment

gpx: init at 2.5.2 #37150

gpx: init at 2.5.2 #37150

Conversation

leo60228 commented Mar 15, 2018 • edited

Motivation for this change

Things done

leo60228 commented Mar 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leo60228 commented Mar 15, 2018

jfrankenau commented Mar 15, 2018

leo60228 commented Mar 15, 2018

jfrankenau commented Mar 15, 2018

leo60228 commented Mar 15, 2018

grahamc commented Mar 16, 2018

Choose a reason for hiding this comment

leo60228 commented Mar 16, 2018

ryantm commented Mar 16, 2018

GrahamcOfBorg commented Mar 16, 2018

GrahamcOfBorg commented Mar 16, 2018

GrahamcOfBorg commented Mar 16, 2018

ryantm left a comment

Choose a reason for hiding this comment

leo60228 commented Mar 15, 2018 •

edited