Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alot: Put included themes where alot will find them #38871

Merged
merged 1 commit into from Apr 12, 2018
Merged

alot: Put included themes where alot will find them #38871

merged 1 commit into from Apr 12, 2018

Conversation

mkaito
Copy link
Contributor

@mkaito mkaito commented Apr 12, 2018

Motivation for this change

Instead of putthing them in the wrong place and then pointing alog at it
via default config, put them in the right place and don't touch the
default config.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

alot: Put included themes where alot will find them
44a7be9 
Instead of putthing them in the wrong place and then pointing alog at it
via default config, put them in the right place and don't touch the
default config.
@mkaito mkaito requested a review from FRidh as a code owner April 12, 2018 21:14
@lukateras lukateras merged commit 4784875 into NixOS:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkaito @lukateras @GrahamcOfBorg