Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 2.4.0 -> 2.5.0 #38873

Merged
merged 1 commit into from Apr 12, 2018
Merged

radare2: 2.4.0 -> 2.5.0 #38873

merged 1 commit into from Apr 12, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 12, 2018

Fixes previous -> 2.5.0 update,
checked r2 -v.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Apr 12, 2018

(see #38872)

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: radare2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: radare2

Partial log (click to expand)

shrinking /nix/store/pa0x6fich1wb1cqf2dd2p9965yc80fqn-radare2-2.5.0/lib/libr_reg.so.2.5.0
shrinking /nix/store/pa0x6fich1wb1cqf2dd2p9965yc80fqn-radare2-2.5.0/lib/libr2.so.2.5.0
gzipping man pages under /nix/store/pa0x6fich1wb1cqf2dd2p9965yc80fqn-radare2-2.5.0/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pa0x6fich1wb1cqf2dd2p9965yc80fqn-radare2-2.5.0/lib  /nix/store/pa0x6fich1wb1cqf2dd2p9965yc80fqn-radare2-2.5.0/bin
patching script interpreter paths in /nix/store/pa0x6fich1wb1cqf2dd2p9965yc80fqn-radare2-2.5.0
/nix/store/pa0x6fich1wb1cqf2dd2p9965yc80fqn-radare2-2.5.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/pa0x6fich1wb1cqf2dd2p9965yc80fqn-radare2-2.5.0/bin/ragg2-cc: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /tmp/nix-build-radare2-2.5.0.drv-0 in /nix/store/pa0x6fich1wb1cqf2dd2p9965yc80fqn-radare2-2.5.0...
/nix/store/pa0x6fich1wb1cqf2dd2p9965yc80fqn-radare2-2.5.0

@dtzWill dtzWill merged commit b21283e into NixOS:master Apr 12, 2018
@dtzWill dtzWill deleted the updatea/radare2-2.5.0 branch April 12, 2018 21:50
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: radare2

Partial log (click to expand)

shrinking /nix/store/y17d4fyl6ggvgb2cpgmqp901h06dgwqy-radare2-2.5.0/lib/libr_asm.so.2.5.0
shrinking /nix/store/y17d4fyl6ggvgb2cpgmqp901h06dgwqy-radare2-2.5.0/lib/libr_anal.so.2.5.0
gzipping man pages under /nix/store/y17d4fyl6ggvgb2cpgmqp901h06dgwqy-radare2-2.5.0/share/man/
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y17d4fyl6ggvgb2cpgmqp901h06dgwqy-radare2-2.5.0/lib  /nix/store/y17d4fyl6ggvgb2cpgmqp901h06dgwqy-radare2-2.5.0/bin
patching script interpreter paths in /nix/store/y17d4fyl6ggvgb2cpgmqp901h06dgwqy-radare2-2.5.0
/nix/store/y17d4fyl6ggvgb2cpgmqp901h06dgwqy-radare2-2.5.0/bin/ragg2-cc: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
/nix/store/y17d4fyl6ggvgb2cpgmqp901h06dgwqy-radare2-2.5.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/y17d4fyl6ggvgb2cpgmqp901h06dgwqy-radare2-2.5.0...
/nix/store/y17d4fyl6ggvgb2cpgmqp901h06dgwqy-radare2-2.5.0

@pbogdan
Copy link
Member

pbogdan commented Apr 12, 2018

FYI the capstone hash does appear to have changed:

fixed-output derivation produced path '/nix/store/k7i63jxmdfkrc5906slp1f7vb80f40sv-capstone-4a1b580' with sha256 hash '19vfgdfykmi3cfs4x1acxy0gnwggjjc8qq46pybqvcksbi11nw1k' instead of the expected hash '1b126npshdbwh5y7rafmb9w4dzlvxsf4ca6bx4zs2y7kbk48jyn8'

@dtzWill dtzWill mentioned this pull request Apr 12, 2018
Merged
8 tasks
@dtzWill
Copy link
Member Author

dtzWill commented Apr 12, 2018 •
edited

So that's what was going on with the previous update? Hmm.

Strange to see this since we .. fetch capstone by git rev?? o_O

Thanks for pointing this out!

@pbogdan
Copy link
Member

pbogdan commented Apr 12, 2018

blames leaveDotGit

@Mic92
Copy link
Member

Mic92 commented Apr 13, 2018 •
edited

I blame the same. I look if I can find a way to do it without leaveDotGit.

@Mic92
Copy link
Member

Mic92 commented Apr 13, 2018

fixed in my other pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @pbogdan @Mic92