Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2-cutter: 1.1 -> 1.3 #38877

Merged
merged 2 commits into from Apr 13, 2018
Merged

radare2-cutter: 1.1 -> 1.3 #38877

merged 2 commits into from Apr 13, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 12, 2018 •
edited

Motivation for this change

we now have both a new version of cutter and radare2. Are the bugs fixed all now, you had before @dtzWill ?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from dtzWill April 12, 2018 22:18
@Mic92 Mic92 changed the title Radare2 radare2: 2.4.0 -> 2.5.0 Apr 12, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: radare2, radare2-cutter

Partial log (click to expand)

shrinking /nix/store/xj82vpqgl10v5pdlqlfh76dc1wi8jw2w-radare2-cutter-1.3/bin/Cutter
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xj82vpqgl10v5pdlqlfh76dc1wi8jw2w-radare2-cutter-1.3/bin
patching script interpreter paths in /nix/store/xj82vpqgl10v5pdlqlfh76dc1wi8jw2w-radare2-cutter-1.3
checking for references to /tmp/nix-build-radare2-cutter-1.3.drv-0 in /nix/store/xj82vpqgl10v5pdlqlfh76dc1wi8jw2w-radare2-cutter-1.3...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/pa0x6fich1wb1cqf2dd2p9965yc80fqn-radare2-2.5.0
/nix/store/xj82vpqgl10v5pdlqlfh76dc1wi8jw2w-radare2-cutter-1.3

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: radare2, radare2-cutter

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@dtzWill
Copy link
Member

dtzWill commented Apr 12, 2018

radare2 2.5.0 was done with #38873, sorry was trying to help O:).

Trying cutter 1.3 presently, thanks for checking... will report back shortly!

@dtzWill
Copy link
Member

dtzWill commented Apr 12, 2018 •
edited

Quick look says it's good, thanks! 👍

dtzWill
dtzWill approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@dtzWill dtzWill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The radare2 version update is already in master, so might want to drop it but might not be a problem when merging.

@dtzWill
Copy link
Member

dtzWill commented Apr 12, 2018

Bah, seems something is going on re:capstone --sorry if I bungled that. See: #38873 (comment)

Can you take a look? I'm okay just bumping to new capstone sha256 although an explanation would be nice but not required... :)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: radare2, radare2-cutter

Partial log (click to expand)

shrinking /nix/store/ssiixd0b6pr6dp445sdgzp9ig2qnypkh-radare2-cutter-1.3/bin/Cutter
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ssiixd0b6pr6dp445sdgzp9ig2qnypkh-radare2-cutter-1.3/bin
patching script interpreter paths in /nix/store/ssiixd0b6pr6dp445sdgzp9ig2qnypkh-radare2-cutter-1.3
checking for references to /build in /nix/store/ssiixd0b6pr6dp445sdgzp9ig2qnypkh-radare2-cutter-1.3...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/y17d4fyl6ggvgb2cpgmqp901h06dgwqy-radare2-2.5.0
/nix/store/ssiixd0b6pr6dp445sdgzp9ig2qnypkh-radare2-cutter-1.3

@Mic92 Mic92 changed the title radare2: 2.4.0 -> 2.5.0 radare2-cutter: 1.1 -> 1.3 Apr 13, 2018
@Mic92
Copy link
Member Author

Mic92 commented Apr 13, 2018

Now radare2 no longer tries to update git.

@Mic92 Mic92 merged commit f204bdf into NixOS:master Apr 13, 2018
@Mic92 Mic92 deleted the radare2 branch April 13, 2018 09:29
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: radare2, radare2-cutter

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: radare2, radare2-cutter

Partial log (click to expand)

shrinking /nix/store/zald7i0klja10c3srbfc932xlwih8hkn-radare2-cutter-1.3/bin/Cutter
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zald7i0klja10c3srbfc932xlwih8hkn-radare2-cutter-1.3/bin
patching script interpreter paths in /nix/store/zald7i0klja10c3srbfc932xlwih8hkn-radare2-cutter-1.3
checking for references to /tmp/nix-build-radare2-cutter-1.3.drv-0 in /nix/store/zald7i0klja10c3srbfc932xlwih8hkn-radare2-cutter-1.3...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/lzxsinz7i528gi3psxrj0rirhhizi7js-radare2-2.5.0
/nix/store/zald7i0klja10c3srbfc932xlwih8hkn-radare2-cutter-1.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: radare2, radare2-cutter

Partial log (click to expand)

shrinking /nix/store/45zdq4lix4zpci2kqxks6cdi4i8rr2j7-radare2-cutter-1.3/bin/Cutter
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/45zdq4lix4zpci2kqxks6cdi4i8rr2j7-radare2-cutter-1.3/bin
patching script interpreter paths in /nix/store/45zdq4lix4zpci2kqxks6cdi4i8rr2j7-radare2-cutter-1.3
checking for references to /build in /nix/store/45zdq4lix4zpci2kqxks6cdi4i8rr2j7-radare2-cutter-1.3...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/lh9fc0qyf9cc5dz6d8hws6rrd75bazxk-radare2-2.5.0
/nix/store/45zdq4lix4zpci2kqxks6cdi4i8rr2j7-radare2-cutter-1.3

@dtzWill
Copy link
Member

dtzWill commented Apr 13, 2018

\o/ thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill dtzWill approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @dtzWill