Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.root_numpy: fix build #38142

Merged
merged 1 commit into from Apr 1, 2018
Merged

pythonPackages.root_numpy: fix build #38142

merged 1 commit into from Apr 1, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 30, 2018

Motivation for this change

Build has failed ever since checks were enabled by default. checkPhase needs to run nosetest.

/cc ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
pythonPackages.root_numpy: fix build
ebd4d38 
checkPhase must use nosetest
@xeji xeji requested a review from FRidh as a code owner March 30, 2018 18:29
@xeji
Copy link
Contributor Author

xeji commented Mar 30, 2018

@GrahamcOfBorg build python.pkgs.root_numpy

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python.pkgs.root_numpy

Partial log (click to expand)

root_numpy.tests.test_utils.test_stack ... ok
root_numpy.tests.test_utils.test_dup_idx ... ok
root_numpy.tests.test_utils.test_stretch ... ok
root_numpy.tests.test_utils.test_blockwise_inner_join ... ok

----------------------------------------------------------------------
Ran 227 tests in 4.682s

OK
/nix/store/yqjmzhxw8cr6zgbmb5zklmkbmcg8a078-python2.7-root_numpy-4.7.3

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python.pkgs.root_numpy

Partial log (click to expand)

make[3]: Leaving directory '/build/gsl-2.4/linalg'
make[2]: *** [Makefile:859: check-TESTS] Error 2
make[2]: Leaving directory '/build/gsl-2.4/linalg'
make[1]: *** [Makefile:930: check-am] Error 2
make[1]: Leaving directory '/build/gsl-2.4/linalg'
make: *** [Makefile:961: check-recursive] Error 1
builder for '/nix/store/qld87hsx4y62izvlal4kr084k0rv6v9h-gsl-2.4.drv' failed with exit code 2
cannot build derivation '/nix/store/q9klm54y7yqbjis3gqcg4p4la7g86w16-root-6.12.06.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/p4rnj2xfpl4v6mb3ql75xsmhs1nnfk8n-python2.7-root_numpy-4.7.3.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/p4rnj2xfpl4v6mb3ql75xsmhs1nnfk8n-python2.7-root_numpy-4.7.3.drv' failed

@xeji
Copy link
Contributor Author

xeji commented Mar 30, 2018

aarch64 failure looks unrelated to this PR.

@fpletz fpletz merged commit 850f5ae into NixOS:master Apr 1, 2018
@xeji xeji deleted the p/root_numpy branch April 2, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @fpletz