Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sddm: add missing include for gettimeofday, fix w/musl #38177

Merged
merged 1 commit into from Mar 31, 2018
Merged

sddm: add missing include for gettimeofday, fix w/musl #38177

merged 1 commit into from Mar 31, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 31, 2018

Fix build w/musl by providing include that is needed when using gettimeofday.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 31, 2018

@GrahamcOfBorg test sddm

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.sddm

No partial log is available.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sddm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux

Attempted: tests.sddm

No partial log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sddm

Partial log (click to expand)

shrinking /nix/store/cmmw4qksbymqkx6776iq4jpk7jvbmb69-sddm-0.17.0/bin/sddm-greeter
shrinking /nix/store/cmmw4qksbymqkx6776iq4jpk7jvbmb69-sddm-0.17.0/libexec/sddm-helper
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cmmw4qksbymqkx6776iq4jpk7jvbmb69-sddm-0.17.0/lib  /nix/store/cmmw4qksbymqkx6776iq4jpk7jvbmb69-sddm-0.17.0/libexec  /nix/store/cmmw4qksbymqkx6776iq4jpk7jvbmb69-sddm-0.17.0/bin
patching script interpreter paths in /nix/store/cmmw4qksbymqkx6776iq4jpk7jvbmb69-sddm-0.17.0
/nix/store/cmmw4qksbymqkx6776iq4jpk7jvbmb69-sddm-0.17.0/share/sddm/scripts/Xsession: interpreter directive changed from " /bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/cmmw4qksbymqkx6776iq4jpk7jvbmb69-sddm-0.17.0/share/sddm/scripts/wayland-session: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/cmmw4qksbymqkx6776iq4jpk7jvbmb69-sddm-0.17.0...
postPatchMkspecs
postPatchMkspecs

@dtzWill dtzWill merged commit ba6299e into NixOS:staging Mar 31, 2018
@dtzWill dtzWill deleted the fix/sddm-missing-include branch March 31, 2018 06:23
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: sddm

Partial log (click to expand)

  CCLD     textiter
building of '/nix/store/q1a0r20gr5rfif2lf3dh6yfnih2ypyzy-gtk+3-3.22.29.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/3jmfab2pjx0wz8ggaa3h7vndq9fykjiq-qtbase-5.10.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bh0ba24wka61w1mv94dfawc7nrhmpc5d-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/i57fmkbxh338c6qxhapsdy8x35d9wjan-qtsvg-5.10.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/nn8x2apwqlbxqqr0wc4x4vrzv0pv4jnv-qttools-5.10.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/j5ba5j0b600rk8jfcwcg1qhp3132rl8a-qtxmlpatterns-5.10.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/h5m9awvfy7xq91bby2s72pbwaaa119v1-qtdeclarative-5.10.1.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/28y81xkhvchjv42dk40mgfhgzck2y0hr-sddm-0.17.0.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/28y81xkhvchjv42dk40mgfhgzck2y0hr-sddm-0.17.0.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg