Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icewm: rename strlcat/strlcpy to avoid conflicts, patch to fix w/musl #38176

Merged
merged 1 commit into from Mar 31, 2018
Merged

icewm: rename strlcat/strlcpy to avoid conflicts, patch to fix w/musl #38176

merged 1 commit into from Mar 31, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 31, 2018

Mostly to fix things w/musl.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: icewm

Partial log (click to expand)

shrinking /nix/store/sff28173y1vami6630vwkaklxy0y294g-icewm-1.4.2/bin/icewm-menu-fdo
shrinking /nix/store/sff28173y1vami6630vwkaklxy0y294g-icewm-1.4.2/bin/icewmhint
shrinking /nix/store/sff28173y1vami6630vwkaklxy0y294g-icewm-1.4.2/bin/icewm
shrinking /nix/store/sff28173y1vami6630vwkaklxy0y294g-icewm-1.4.2/bin/icesh
gzipping man pages under /nix/store/sff28173y1vami6630vwkaklxy0y294g-icewm-1.4.2/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sff28173y1vami6630vwkaklxy0y294g-icewm-1.4.2/bin
patching script interpreter paths in /nix/store/sff28173y1vami6630vwkaklxy0y294g-icewm-1.4.2
/nix/store/sff28173y1vami6630vwkaklxy0y294g-icewm-1.4.2/bin/icewm-set-gnomewm: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/sff28173y1vami6630vwkaklxy0y294g-icewm-1.4.2...

@dtzWill
Copy link
Member Author

dtzWill commented Mar 31, 2018

@GrahamcOfBorg test sddm slim

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: icewm

Partial log (click to expand)

shrinking /nix/store/xyk8j2bwbggzjvj914d6r395wqyknr3a-icewm-1.4.2/bin/icesh
shrinking /nix/store/xyk8j2bwbggzjvj914d6r395wqyknr3a-icewm-1.4.2/bin/icewm
shrinking /nix/store/xyk8j2bwbggzjvj914d6r395wqyknr3a-icewm-1.4.2/bin/icehelp
shrinking /nix/store/xyk8j2bwbggzjvj914d6r395wqyknr3a-icewm-1.4.2/bin/icewm-menu-fdo
gzipping man pages under /nix/store/xyk8j2bwbggzjvj914d6r395wqyknr3a-icewm-1.4.2/share/man/
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xyk8j2bwbggzjvj914d6r395wqyknr3a-icewm-1.4.2/bin
patching script interpreter paths in /nix/store/xyk8j2bwbggzjvj914d6r395wqyknr3a-icewm-1.4.2
/nix/store/xyk8j2bwbggzjvj914d6r395wqyknr3a-icewm-1.4.2/bin/icewm-set-gnomewm: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/xyk8j2bwbggzjvj914d6r395wqyknr3a-icewm-1.4.2...

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: icewm

Partial log (click to expand)

cannot build derivation '/nix/store/n35gwc3wrdhxh3whk5cmvggm9rk9vcsx-apple-framework-QuartzCore.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/grvi8pypvgba2b0silx6nlv5m0lddnl3-cmake-3.10.2.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/98lnkfrm8gsvj2cr279rijf0ai8l9y05-apple-framework-Carbon.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/lii6flg3718n81zg2fis8lrayn52jla0-jasper-2.0.14.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/93b7wf4kb8wp82hf1kkcb3wbpgab2mvr-cairo-1.14.10.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/rl3sx3qhmkv9fhza6sbcimqd4rc3dcq6-absolute_gir_path.patch.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/8mzl2c7sjdhlpjkb5ig3s6vv25w0rkrb-gobject-introspection-1.56.0.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/hhxhys8i44lprfivmns1fpzrcyawpc1v-gdk-pixbuf-2.36.7.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/f3ra6yim9y3rnpmfmykr180qdfx2akdx-icewm-1.4.2.drv': 27 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/f3ra6yim9y3rnpmfmykr180qdfx2akdx-icewm-1.4.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.sddm, tests.slim

Partial log (click to expand)

cannot build derivation '/nix/store/04j7yh5j0fxb8311g19dyph6lg3c5xdv-unit-display-manager.service.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/naav6zql3q7sc7bv091fqq5ashg18nmr-system-units.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/yjn0b8y8sivibysm71yhx58pwnmfqxcr-etc.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/a7cfkll0c81fmfh4s7awdahb6vl8pzwk-nixos-system-machine-18.09.git.fcf3ce3.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/akprmvhs1rfilfazaljam9m6lgyiycm2-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/q1lls2y4565j8jvdw0rhb8qxr696wn87-run-nixos-vm.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/hdf4ibiqgdghlb166asgd7nrb6bgcc0w-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/wm30y90w40s3sp5k9b5js3ja3qs7dg4h-nixos-test-driver-slim.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/wjjidl5fd5i7rxcn2sc9l4mpjkbzd9qy-vm-test-run-slim.drv': 1 dependencies couldn't be built
error: build of '/nix/store/wjjidl5fd5i7rxcn2sc9l4mpjkbzd9qy-vm-test-run-slim.drv' failed

@dtzWill dtzWill merged commit f64c199 into NixOS:staging Mar 31, 2018
@dtzWill dtzWill deleted the fix/icewm-musl branch March 31, 2018 08:29
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.sddm, tests.slim

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3qgj84zdssif2xdy1afrmsdslgy356jk-nixos-test-driver
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3qgj84zdssif2xdy1afrmsdslgy356jk-nixos-test-driver/lib  /nix/store/3qgj84zdssif2xdy1afrmsdslgy356jk-nixos-test-driver/bin
patching script interpreter paths in /nix/store/3qgj84zdssif2xdy1afrmsdslgy356jk-nixos-test-driver
/nix/store/3qgj84zdssif2xdy1afrmsdslgy356jk-nixos-test-driver/bin/.nixos-test-driver-wrapped: interpreter directive changed from " /somewhere/perl -w" to "/nix/store/3qhzffjvl8gbiabikiqdnz4jhh9v84nz-perl-5.24.3/bin/perl -w"
checking for references to /build in /nix/store/3qgj84zdssif2xdy1afrmsdslgy356jk-nixos-test-driver...
cannot build derivation '/nix/store/w709brx8shir20rclvfs6rnygzi5kl3i-nixos-test-driver-slim.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4ybwxp5afivxx7z051cn39xnsdx88q6f-vm-test-run-slim.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/4ybwxp5afivxx7z051cn39xnsdx88q6f-vm-test-run-slim.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg