gflags: fix build on case-insensitive filesystems #38157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperiodic
force-pushed
the
gflags-darwin-fix
branch
from
3b90d38
to
2b4b0bb
Compare
aperiodic
changed the title
|
@GrahamcOfBorg build gflags |
|
Success on x86_64-darwin (full log) Attempted: gflags Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gflags Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: gflags Partial log (click to expand)
|
LnL7
reviewed
Mar 31, 2018
| # a directory called 'build'. To fix building on the case-insensitive | ||
| # filesystems commonly seen on darwin machines, rename 'BUILD' so it won't | ||
| # conflict with the directory (it's for the unrelated build tool "bazel"). | ||
| prePatch = "mv BUILD BUILD.bazel"; | ||
| } |
There was a problem hiding this comment.
Could you also add meta.platforms, otherwise this won't get built by hydra.
aperiodic
force-pushed
the
gflags-darwin-fix
branch
from
2b4b0bb
to
bd4d928
Compare
aperiodic
requested review from
edolstra,
edwtjo,
Ericson2314,
FRidh,
nbp,
orivej,
peti,
Profpatsch,
rycee,
ttuegel and
zimbatm
as code owners
aperiodic
force-pushed
the
gflags-darwin-fix
branch
from
bd4d928
to
b70a1af
Compare
|
@LnL7 Added platforms along with some other metadata. |
|
Uh sorry for the review pings everyone, I forgot I rebased against 17.09 locally to try my changes out. |
|
looks like you forgot a semicolon after one of the attributes. |
Darwin machines come with a case-insensitive filesystem by default. The gflags package's source contains a file 'BUILD' and the build process attempts to create a directory called 'build', which fails on case-insensitive filesystems. Add a prePatch hook to rename the BUILD file (which is for use with an unrelated build tool) to something that doesn't conflict with the 'build' directory. This hook allows this derivation to be built on case-insensitive filesystems. Add metadata to the derivation because previously it had none.
aperiodic
force-pushed
the
gflags-darwin-fix
branch
from
b70a1af
to
66bbee3
Compare
GrahamcOfBorg
added
8.has: package (new)
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
labels
|
@GrahamcOfBorg build gflags |
|
Success on x86_64-darwin (full log) Attempted: gflags Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: gflags Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gflags Partial log (click to expand)
|
|
Also ported to release in 021ee7d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Darwin machines come with a case-insensitive filesystem by default. The
gflags package's source contains a file 'BUILD' and the build process
attempts to create a directory called 'build', which fails on
case-insensitive filesystems.
Things done
Add a prePatch hook to rename the BUILD file (which is for use with an unrelated build tool).
Tested using sandboxing (nix.useSandbox on NixOS, or option
build-use-sandboxinnix.confon non-NixOS)Built on platform(s)
I did not test compilation of all pkgs that depend on this change because this should not produce a change to any machine code
Tested execution of the bash completion script in bin
Fits CONTRIBUTING.md.