Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gmtp: pass --datapath in the wrapper #38152

Merged
merged 1 commit into from Apr 17, 2018
Merged

gmtp: pass --datapath in the wrapper #38152

merged 1 commit into from Apr 17, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Mar 30, 2018

Motivation for this change

Some icons (locales maybe too...?) are missing. Seems like a minor change that could perhaps be included in 18.03 as well?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pbogdan
gmtp: pass --datapath in the wrapper
38f7dae 
gmtp gets somewhat confused trying to lookup some of its own assets when
installed system-wide. It first attempts to locate the path to its own binary by
searching for itself in $PATH, arrives at /run/current-system/sw/bin/gmtp, and
then performs lookups relative to that path without dereferencing the
symlink. Some of the lookups result in searching for, for example, icons in
/run/current-system/sw/bin/../share/gmtp/ which doesn't exist.
@pbogdan
Copy link
Member Author

pbogdan commented Mar 30, 2018

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gmtp

Partial log (click to expand)

make[1]: Leaving directory '/tmp/nix-build-gmtp-1.3.11.drv-0/gmtp-1.3.11'
glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/m5ir8jnyjhfjsjl1zzlw15v7p87n1gdd-gmtp-1.3.11/bin/gmtp
shrinking RPATHs of ELF executables and libraries in /nix/store/m5ir8jnyjhfjsjl1zzlw15v7p87n1gdd-gmtp-1.3.11
shrinking /nix/store/m5ir8jnyjhfjsjl1zzlw15v7p87n1gdd-gmtp-1.3.11/bin/.gmtp-wrapped
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/m5ir8jnyjhfjsjl1zzlw15v7p87n1gdd-gmtp-1.3.11/bin
patching script interpreter paths in /nix/store/m5ir8jnyjhfjsjl1zzlw15v7p87n1gdd-gmtp-1.3.11
checking for references to /tmp/nix-build-gmtp-1.3.11.drv-0 in /nix/store/m5ir8jnyjhfjsjl1zzlw15v7p87n1gdd-gmtp-1.3.11...

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gmtp

Partial log (click to expand)

   Compiling rustc_allocator v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_allocator)
   Compiling rustc_mir v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_mir)
   Compiling rustc_lint v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_lint)
   Compiling rustc_passes v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_passes)
building of '/nix/store/whsyh46wr0zfkw420xcc8ffgahszsd80-rustc-1.24.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/nfjkyviyyy9ly6hq1pj5wzy6qxmd491n-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bbqaq71xj30lggbbbf6calm3g7g56c02-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/0hjhsl89xb2yh8m4w00jk2jg1kbqhjzs-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lk0hcjg8zmd5ckh5ldhg76jrva97inb9-gmtp-1.3.11.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/lk0hcjg8zmd5ckh5ldhg76jrva97inb9-gmtp-1.3.11.drv' failed

@matthewbauer matthewbauer merged commit 210d474 into NixOS:master Apr 17, 2018
@pbogdan pbogdan deleted the gmtp-datapath branch December 3, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @GrahamcOfBorg @matthewbauer