Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.smart_open: fix build, 1.5.6 -> 1.5.7 #38151

Merged
merged 1 commit into from Apr 1, 2018
Merged

pythonPackages.smart_open: fix build, 1.5.6 -> 1.5.7 #38151

merged 1 commit into from Apr 1, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 30, 2018

Motivation for this change

ZHF #36453

Previous version didn't build (according to available Hydra logs, 1.5.6 never built - last successful build was 1.5.3). Had to disable tests because they are incompatible with nixpkgs version of moto, causing some of the tests to fail.

/cc maintainer @jyp

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji xeji requested a review from FRidh as a code owner March 30, 2018 21:10
@xeji
Copy link
Contributor Author

xeji commented Mar 30, 2018

@GrahamcOfBorg build python27Packages.smart_open python36Packages.smart_open

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.smart_open, python36Packages.smart_open

Partial log (click to expand)

Successfully installed smart-open-1.5.7
/build/smart_open-1.5.7
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8iq1hg8m1lc6azrarc344pqa74axlf0y-python3.6-smart_open-1.5.7
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/8iq1hg8m1lc6azrarc344pqa74axlf0y-python3.6-smart_open-1.5.7/lib
patching script interpreter paths in /nix/store/8iq1hg8m1lc6azrarc344pqa74axlf0y-python3.6-smart_open-1.5.7
checking for references to /build in /nix/store/8iq1hg8m1lc6azrarc344pqa74axlf0y-python3.6-smart_open-1.5.7...
/nix/store/9387fr4wrkvmhi0c80n5588932lh2nis-python2.7-smart_open-1.5.7
/nix/store/8iq1hg8m1lc6azrarc344pqa74axlf0y-python3.6-smart_open-1.5.7

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.smart_open, python36Packages.smart_open

Partial log (click to expand)

Successfully installed smart-open-1.5.7
/tmp/nix-build-python3.6-smart_open-1.5.7.drv-0/smart_open-1.5.7
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mygxx8fz0ialbna001ffv3gxg3g0wlk5-python3.6-smart_open-1.5.7
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/mygxx8fz0ialbna001ffv3gxg3g0wlk5-python3.6-smart_open-1.5.7/lib
patching script interpreter paths in /nix/store/mygxx8fz0ialbna001ffv3gxg3g0wlk5-python3.6-smart_open-1.5.7
checking for references to /tmp/nix-build-python3.6-smart_open-1.5.7.drv-0 in /nix/store/mygxx8fz0ialbna001ffv3gxg3g0wlk5-python3.6-smart_open-1.5.7...
/nix/store/5wz8wj6kaidw9iyxm2c66xriaz8cm6nl-python2.7-smart_open-1.5.7
/nix/store/mygxx8fz0ialbna001ffv3gxg3g0wlk5-python3.6-smart_open-1.5.7

@jyp
Copy link
Contributor

jyp commented Apr 1, 2018

👍

@fpletz fpletz merged commit de1e189 into NixOS:master Apr 1, 2018
@xeji xeji deleted the p/smart_open branch April 2, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xeji @GrahamcOfBorg @jyp @fpletz