Updates gstreamer and plugins to 1.14.0 #38149

bkchr · 2018-03-30T19:25:38Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

jtojnar · 2018-03-30T20:54:39Z

While at it, could you please also try to port the packages to meson as per #32803?

jtojnar · 2018-03-31T14:49:35Z

pkgs/development/libraries/gstreamer/core/default.nix

  postInstall = ''
    for prog in "$dev/bin/"*; do
        wrapProgram "$prog" --suffix GST_PLUGIN_SYSTEM_PATH : "\$(unset _tmp; for profile in \$NIX_PROFILES; do _tmp="\$profile/lib/gstreamer-1.0''$\{_tmp:+:\}\$_tmp"; done; printf "\$_tmp")"
    done
  '';

+  preConfigure= ''
+    configureFlagsArray+=("--exec-prefix=$dev")


This will not be used with meson, so you can just remove it. Actually, it does not seem to do anything even with autotools.

jtojnar · 2018-03-31T14:50:00Z

pkgs/development/libraries/gstreamer/core/default.nix

  ];
-  buildInputs = stdenv.lib.optional stdenv.isDarwin darwin.apple_sdk.frameworks.CoreServices;
+  buildInputs = [ libcap libunwind ] ++ stdenv.lib.optional stdenv.isDarwin darwin.apple_sdk.frameworks.CoreServices;

  propagatedBuildInputs = [ glib ];

  enableParallelBuilding = true;


This can be removed as well, meson does this by default.

bkchr · 2018-03-31T22:23:55Z

@jtojnar I ported everything to meson :)
gst-validate could not be ported, because the released package does not contain the meson files. I don't know why they are missing..

jtojnar · 2018-04-01T02:07:24Z

pkgs/development/libraries/gstreamer/bad/fix_pkgconfig_includedir.patch

+@@ -3,7 +3,7 @@ pkgconf = configuration_data()
+ pkgconf.set('prefix', join_paths(get_option('prefix')))
+ pkgconf.set('exec_prefix', '${prefix}')
+ pkgconf.set('libdir', '${prefix}/@0@'.format(get_option('libdir')))


The libdir needs the same fix as includedir.

jtojnar · 2018-04-01T02:10:31Z

pkgs/development/libraries/gstreamer/base/fix_pkgconfig_includedir.patch

+@@ -3,7 +3,7 @@ pkgconf = configuration_data()
+ pkgconf.set('prefix', get_option('prefix'))
+ pkgconf.set('exec_prefix', '${prefix}')
+ pkgconf.set('libdir', '${prefix}/@0@'.format(get_option('libdir')))


The libdir needs the same fix as includedir.

jtojnar · 2018-04-01T02:12:13Z

pkgs/development/libraries/gstreamer/core/default.nix

  outputs = [ "out" "dev" ];
  outputBin = "dev";

  nativeBuildInputs = [
-    pkgconfig perl bison flex python gobjectIntrospection makeWrapper
+    meson ninja pkgconfig gettext bison flex python3 makeWrapper valgrind gtk3 gsl


Why id gtk3 in nativeBuildInputs? If it is for tests, could you please add a comment?

jtojnar · 2018-04-01T02:12:39Z

pkgs/development/libraries/gstreamer/core/fix_pkgconfig_includedir.patch

+@@ -3,7 +3,7 @@ pkgconf = configuration_data()
+ pkgconf.set('prefix', join_paths(get_option('prefix')))
+ pkgconf.set('exec_prefix', '${prefix}')
+ pkgconf.set('libdir', '${prefix}/@0@'.format(get_option('libdir')))


The libdir needs the same fix as includedir.

jtojnar · 2018-04-01T02:13:31Z

pkgs/development/libraries/gstreamer/ges/fix_pkgconfig_includedir.patch

+@@ -3,7 +3,7 @@ pkgconf = configuration_data()
+ pkgconf.set('prefix', get_option('prefix'))
+ pkgconf.set('exec_prefix', '${prefix}')
+ pkgconf.set('libdir', '${prefix}/@0@'.format(get_option('libdir')))


The libdir needs the same fix as includedir.

jtojnar · 2018-04-01T03:10:58Z

pkgs/development/libraries/gstreamer/bad/default.nix

  };

  outputs = [ "out" "dev" ];

-  nativeBuildInputs = [ pkgconfig python ];
+  nativeBuildInputs = [ meson ninja pkgconfig python ];


gettext is missing.

Why isn't gettext and ninja automatically propagated by meson? But I will add it.

Not every project uses i18n. And ninja is not needed for meson to work, you can use other builders.

jtojnar · 2018-04-01T03:12:12Z

pkgs/development/libraries/gstreamer/base/default.nix

  };

  outputs = [ "out" "dev" ];

  nativeBuildInputs = [
-    pkgconfig python gobjectIntrospection
+    pkgconfig python meson ninja


gettext is missing.

jtojnar · 2018-04-01T03:15:15Z

pkgs/development/libraries/gstreamer/ges/default.nix

  };

  outputs = [ "out" "dev" ];

-  nativeBuildInputs = [ pkgconfig python gobjectIntrospection flex perl ];


Why are you removing gobjectIntrospection?

jtojnar · 2018-04-01T03:17:51Z

pkgs/development/libraries/gstreamer/rtsp-server/default.nix

  };

  outputs = [ "out" "dev" ];

-  nativeBuildInputs = [ pkgconfig ];
+  nativeBuildInputs = [ meson ninja pkgconfig ];


gobjectIntrospection is missing.

jtojnar · 2018-04-01T03:19:11Z

pkgs/development/libraries/gstreamer/ugly/default.nix

  };

  outputs = [ "out" "dev" ];

-  nativeBuildInputs = [ pkgconfig python ];
+  nativeBuildInputs = [ meson ninja pkgconfig python ];


gettext is missing.

jtojnar · 2018-04-01T10:37:16Z

You might also want to update gst-python.

jtojnar · 2018-04-01T10:47:16Z

Opened an issue about gst-validate lacking meson support: https://bugzilla.gnome.org/show_bug.cgi?id=794871

bkchr · 2018-04-01T16:17:27Z

@jtojnar I think I'm ready now.

Regarding gst-python, I looked into the package and tried porting it to meson, but my knowledge with meson is not that good. Maybe you could look into it?

jtojnar · 2018-04-02T11:34:45Z

pkgs/development/libraries/gstreamer/core/fix_pkgconfig_includedir.patch

+ pkgconf.set('exec_prefix', '${prefix}')
+-pkgconf.set('libdir', '${prefix}/@0@'.format(get_option('libdir')))
+-pkgconf.set('includedir', '${prefix}/@0@'.format(get_option('includedir')))
+pkgconf.set('libdir', get_option('libdir'))


This needs to be absolute. Use join_paths(get_option('prefix'), get_option('ilibdir')).

jtojnar · 2018-04-02T13:16:41Z

pkgs/development/libraries/gstreamer/core/fix_pkgconfig_includedir.patch

+-pkgconf.set('libdir', '${prefix}/@0@'.format(get_option('libdir')))
+-pkgconf.set('includedir', '${prefix}/@0@'.format(get_option('includedir')))
+pkgconf.set('libdir', get_option('libdir'))
+pkgconf.set('includedir', get_option('includedir'))


This probably too, though it works as long we use multiple outputs.

jtojnar · 2018-04-02T14:14:53Z

I am getting the following error when building webkitgtk:

CMake Error in Source/WebCore/CMakeLists.txt:
  Found relative path while evaluating include directories of "WebCore":

    "lib/gstreamer-1.0/include"

jtojnar · 2018-04-02T15:29:20Z

pkgs/development/libraries/gstreamer/base/fix_pkgconfig_includedir.patch

+ pkgconf.set('exec_prefix', '${prefix}')
+-pkgconf.set('libdir', '${prefix}/@0@'.format(get_option('libdir')))
+-pkgconf.set('includedir', '${prefix}/@0@'.format(get_option('includedir')))
+pkgconf.set('libdir', get_option('libdir'))


This path being non-absolute is causing the webkitgtk failure, most likely.

jtojnar · 2018-04-02T15:31:37Z

And for some reason __init__.py files are no longer installed, though arch has the same problem. Maybe open a bug about that?

bkchr · 2018-04-02T16:32:43Z

Yeah, maybe we should open a bug, if the files are not installed anymore.
Did you finish porting gst-python?

jtojnar · 2018-04-02T17:16:09Z

@bkchr the patch I sent on IRC yesterday worked for me, did you try it?

bkchr · 2018-04-02T17:52:57Z

No I did not try. Should I test and push or do you want to push it to my pull request?

jtojnar · 2018-04-02T18:34:15Z

If you can, please.

bkchr · 2018-04-03T12:11:26Z

@jtojnar webkitgtk compiles and also gnome-music. I can't run gnome-music, because it crashes with:
ERROR Cannot connect to tracker, error 'tracker_sparql_error-quark: Failed to load SPARQL backend: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.Tracker1 was not provided by any .service files (6)'\Exiting

I think this error occurs, because I don't have any gnome services running. (I'm using KDE)

jtojnar · 2018-04-03T12:56:39Z

I tested it and it starts fine. I cannot play MP3 files, however:

Info <GstPbutils.DiscovererInfo object at 0x7fe9ca07a1b0 (GstDiscovererInfo at 0x15286e0)>: error: gst-core-error-quark: Your GStreamer installation is missing a plug-in. (12)
14:43:45 WARNING	URI: file:///home/jtojnar/Music/Give%20My%20Love%20To%20London/09-mother_wolf.mp3
14:43:45 WARNING	Error from element mpegaudioparse1: Internal data stream error.
14:43:45 WARNING	Debugging info:
     ../libs/gst/base/gstbaseparse.c(3611): gst_base_parse_loop (): /GstPlayBin:player/GstURIDecodeBin:uridecodebin0/GstDecodeBin:decodebin2/GstMpegAudioParse:mpegaudioparse1:
     streaming stopped, reason not-linked (-1)

Maybe something to do with the move of MP3 codecs to gst-plugins-good I noticed in the release notes? Possibly a flag or library needs to be moved over there.

You can also test with quodlibet (fixed version here #38122, or just add gobjectIntrospection dependency) or any other player using gst-python.

jtojnar · 2018-04-03T17:02:03Z

A bug about the __init__.py not getting installed: https://bugzilla.gnome.org/show_bug.cgi?id=726831

But quodlibet plays FLAC music fine so perhaps we can do without.

bkchr · 2018-04-03T17:04:05Z

But mp3 is not working with quodlibet. Still okay?

jtojnar · 2018-04-03T17:06:17Z

I think that is most likely caused by the move as mentioned above. That should be fixed.

bkchr · 2018-04-03T17:33:03Z

@jtojnar quodlibet now plays mp3 as designed :)

See: https://bugzilla.gnome.org/show_bug.cgi?id=774252

See: https://bugzilla.gnome.org/show_bug.cgi?id=719849

bkchr · 2018-04-04T15:52:44Z

@jtojnar corebird now also works. I'm gone through the list of moved things and fixed everything so far.

jtojnar · 2018-04-04T16:34:34Z

Great job, thanks.

FRidh · 2018-04-04T18:24:04Z

Please check on staging pkgs/development/libraries/gstreamer/{bad,base,good,ugly} because of merge-conflicts.

bkchr · 2018-04-04T20:32:12Z

@FRidh I rebased staging onto my branch and locally and that worked without any merge conflicts?

lukateras · 2018-04-22T00:02:45Z

@bkchr To run gnome-music you will need to enable services.gnome3.tracker.enable and services.gnome3.tracker-miners.enable.

bkchr · 2018-04-22T06:05:02Z

Ahh, ty :)

FRidh · 2018-04-22T06:30:19Z

@bkchr I meant to check the expressions. There was a merge conflict when merging staging and master, so I'm not quite sure the changes you intended survived.

GrahamcOfBorg added 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Mar 30, 2018

GrahamcOfBorg added 8.has: clean-up 10.rebuild-darwin: 0 and removed 10.rebuild-darwin: 11-100 labels Mar 31, 2018

jtojnar reviewed Mar 31, 2018

View reviewed changes

bkchr force-pushed the gst_1_14_0 branch from 183f79c to 4511371 Compare March 31, 2018 22:20

jtojnar requested changes Apr 1, 2018

View reviewed changes

bkchr force-pushed the gst_1_14_0 branch from 4511371 to 55bb5c4 Compare April 1, 2018 15:47

jtojnar requested changes Apr 2, 2018

View reviewed changes

bkchr requested a review from FRidh as a code owner April 3, 2018 07:37

bkchr and others added 19 commits April 4, 2018 17:25

gst-validate: 1.12.3 -> 1.14.0

06f9b94

gst-rtsp-server: 1.12.3 -> 1.14.0

1884beb

gstreamer: Switch to meson build system

365640a

gst-plugins-base: Switch to meson build system

edd17a0

gst-plugins-good: Switch to meson build system

fd0474e

gst-plugins-bad: Switch to meson build system

ac0d32b

gst-plugins-ugly: Switch to meson build system

a19a9b2

gst-rtsp-server: Switch to meson build system

42d3b5c

gst-libav: Switch to meson build system

2a80d83

gst-vaapi: Switch to meson build system

69fb4dd

gst-editing-services: Switch to meson build system

fd5c1f6

gst-gnonlin: Remove package as it is deprecated

3508f30

Switch to absolute path for includedir/libdir

40b4b87

pythonPackages.gst-python: 1.12.3 → 1.14.0

be5bff0

Move dependencies from ugly to good as the code moved

41a4fea

See: https://bugzilla.gnome.org/show_bug.cgi?id=774252

gst-plugins-good: Adds twolame dependency

4a945a0

Moves gtksupport from gst-plugins-good to gst-plugins-bad

9ad4ca1

gst-plugins-bad: Removes unused depdency

e741073

See: https://bugzilla.gnome.org/show_bug.cgi?id=719849

corebird: gtkSupport moved to gst-plugins-good

853a086

bkchr force-pushed the gst_1_14_0 branch from 31b8f1e to 853a086 Compare April 4, 2018 15:51

jtojnar merged commit c490b05 into NixOS:master Apr 4, 2018

mpickering mentioned this pull request Apr 20, 2018

qtmultimedia broken on darwin by gstreamer update #39289

Closed

jtojnar mentioned this pull request Apr 27, 2018

liferea can't play audio #39587

Closed

Updates gstreamer and plugins to 1.14.0 #38149

Updates gstreamer and plugins to 1.14.0 #38149

Conversation

bkchr commented Mar 30, 2018 • edited

Motivation for this change

Things done

jtojnar commented Mar 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bkchr commented Mar 31, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtojnar commented Apr 1, 2018

jtojnar commented Apr 1, 2018

bkchr commented Apr 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtojnar commented Apr 2, 2018

Choose a reason for hiding this comment

jtojnar commented Apr 2, 2018 • edited

bkchr commented Apr 2, 2018

jtojnar commented Apr 2, 2018

bkchr commented Apr 2, 2018

jtojnar commented Apr 2, 2018

bkchr commented Apr 3, 2018

jtojnar commented Apr 3, 2018 • edited

jtojnar commented Apr 3, 2018

bkchr commented Apr 3, 2018

jtojnar commented Apr 3, 2018

bkchr commented Apr 3, 2018

bkchr commented Apr 4, 2018

jtojnar commented Apr 4, 2018

FRidh commented Apr 4, 2018

bkchr commented Apr 4, 2018

lukateras commented Apr 22, 2018

bkchr commented Apr 22, 2018

FRidh commented Apr 22, 2018

bkchr commented Mar 30, 2018 •

edited

jtojnar commented Apr 2, 2018 •

edited

jtojnar commented Apr 3, 2018 •

edited