Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugo: 0.32.2 -> 0.36.1 #38131

Closed
wants to merge 1 commit into from
Closed

hugo: 0.32.2 -> 0.36.1 #38131

wants to merge 1 commit into from

Conversation

monotux
Copy link

@monotux monotux commented Mar 30, 2018

Motivation for this change

Update to a more recent version. Cherry picked from master as I know little to nothing on how to build go packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Mar 30, 2018

@GrahamcOfBorg build hugo

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: hugo

Partial log (click to expand)

Cannot nix-instantiate `hugo' because:
�[31;1merror:�[0m while evaluating the attribute 'buildInputs' of the derivation 'hugo-0.36.1' at �[1m/var/lib/gc-of-borg/nix-test-rs-23/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-23/pkgs/stdenv/generic/make-derivation.nix�[0m:98:11:
while evaluating the attribute 'GOARCH' of the derivation 'go-1.9.2' at �[1m/var/lib/gc-of-borg/nix-test-rs-23/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-23/pkgs/stdenv/generic/make-derivation.nix�[0m:98:11:
Unsupported system

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: hugo

Partial log (click to expand)

github.com/gohugoio/hugo/utils
go/src/github.com/alecthomas/chroma/regexp.go:11:2: cannot find package "github.com/dlclark/regexp2" in any of:
        /nix/store/shyj7ybdlalm3hb101dc2gqz15dk127y-go-1.9.2/share/go/src/github.com/dlclark/regexp2 (from $GOROOT)
        /build/go/src/github.com/dlclark/regexp2 (from $GOPATH)
        /nix/store/iyj0r1k0zacv0xhl9qac8x3dqpifab5r-govers-20150109-3b5f175/share/go/src/github.com/dlclark/regexp2
golang.org/x/sys/unix
github.com/fsnotify/fsnotify
github.com/gohugoio/hugo/watcher
builder for '/nix/store/6ghxbrvwxyacml08h35r4qh0lvws43pk-hugo-0.36.1.drv' failed with exit code 32
�[31;1merror:�[0m build of '/nix/store/6ghxbrvwxyacml08h35r4qh0lvws43pk-hugo-0.36.1.drv' failed

@oscarcarlsson
Copy link
Contributor

Oh, dammit. @peterhoeg could you please have a look at this, since you updated hugo on master?

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: hugo

Partial log (click to expand)

        /nix/store/ar59s225ygs3vyqwgm2a417d6rp3h773-go-1.9.2/share/go/src/github.com/dlclark/regexp2 (from $GOROOT)
        /private/tmp/nix-build-hugo-0.36.1.drv-0/go/src/github.com/dlclark/regexp2 (from $GOPATH)
        /nix/store/azkmi5zrr77f13n6iw4iv8kwrja44p9l-govers-20150109-3b5f175/share/go/src/github.com/dlclark/regexp2
github.com/spf13/jwalterweatherman
github.com/gohugoio/hugo/utils
golang.org/x/sys/unix
github.com/fsnotify/fsnotify
github.com/gohugoio/hugo/watcher
builder for '/nix/store/k0nkmjf4kc9ss1r5n74i7gmmx35y5vgs-hugo-0.36.1.drv' failed with exit code 32
�[31;1merror:�[0m build of '/nix/store/k0nkmjf4kc9ss1r5n74i7gmmx35y5vgs-hugo-0.36.1.drv' failed

ryantm
ryantm reviewed Mar 30, 2018
View reviewed changes
pkgs/applications/misc/hugo/deps.nix
}
{
goPackagePath = "github.com/dlclark/regexp2";
goPackagePath = "github.com/disintegration/imaging";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems suspect, maybe @monotux didn't update the deps with go2nix?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to merge the updates from master to this branch, but I guess I didn't do a very good job :)

Next time I attempt this I will try to really understand how the tooling works.

@peterhoeg
Copy link
Member

peterhoeg commented Mar 31, 2018 via email

@monotux
Copy link
Author

monotux commented Mar 31, 2018

@peterhoeg no, just a version bump. We should probably close this PR, I thought we did updates like this to the stable version.

@peterhoeg peterhoeg closed this Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@monotux @ryantm @GrahamcOfBorg @oscarcarlsson @peterhoeg @Janik-Haag