Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 50b906e0e926^
Choose a base ref
...
head repository: jruby/jruby
compare: 3c5cc91cbf51
Choose a head ref
  • 2 commits
  • 27 files changed
  • 1 contributor

Commits on Mar 20, 2018

  1. No longer generated.

    @headius
    headius committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    50b906e View commit details
    Browse the repository at this point in the history

  2. Make Block.type final. 

    This is cleanup to make simplifying block dispatch more
straightforward. The type field in Block was only set rarely, and
usually just once for a given block when setting it up as e.g.
lambda. All paths now just create a new block with the given type,
which opens up the possibility of Block subclasses specific to
each type (ProcBlock, LambdaBlock) and less conditional logic.

As a side effect of this cleanup, RubyProc fields are now all also
final and it no longer stores a duplicate Block.Type.
    @headius
    headius committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    3c5cc91 View commit details
    Browse the repository at this point in the history