Enumerable#any?, all?, none? and one? now accept a pattern argument #5096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more information, please see feature #11286.
For more information, please see feature #11286.
For more information, please see feature #11286.
For more information, please see feature #11286.
|
Fixed. jruby/spec/ruby/core/enumerable/any_spec.rb Line 214 in 3813f0a All Enumerable tests in ruby-2.5 branch should work with this PR. I still would like to research and understand why that specific test was failing when each with a block built with JavaInternalBlockBody class is passed but not with one built with BlockCallback. |
Replace each call + JavaInternalBlockBody with callEach + BlockCallback as is implemented Enumerable#all? as well. The failed test was: https://github.com/jruby/jruby/blob/3813f0a53c22af8122e8c2b70c7d87ae35323109/spec/ruby/core/enumerable/any_spec.rb#L214
nomadium
deleted the
enumerable-methods-one-none-any-and-all-now-accept-pattern-argument
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
This is another change adding Ruby 2.5 support [1]: Enumerable#any?, all?, none? and one? now accept a pattern argument (feature #11286 [2]).
All associated MRI and ruby/spec tests
(except one [3] for #any?)are passing.Thanks for your review and feedback.
jruby/spec/ruby/core/enumerable/any_spec.rb
Line 214 in 3813f0a