Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-generic-builder: Add enableHsc2hsViaAsm for Windows cross compilation #37479

Merged
merged 1 commit into from
Mar 20, 2018
Merged

haskell-generic-builder: Add enableHsc2hsViaAsm for Windows cross compilation #37479

merged 1 commit into from
Mar 20, 2018
+7 −2

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Mar 20, 2018 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

CC @angerman

Sorry, something went wrong.

@Ericson2314 Ericson2314 requested a review from peti as a code owner March 20, 2018 18:55
@Ericson2314 Ericson2314 added 6.topic: windows Running, or buiding, packages on Windows 6.topic: cross-compilation Building packages on a different platform than they will be used on labels Mar 20, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 20, 2018
@Ericson2314 Ericson2314 merged commit 918edbe into NixOS:master Mar 20, 2018
@Ericson2314 Ericson2314 deleted the hsc2hs-via-asm branch March 20, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: haskell 6.topic: windows Running, or buiding, packages on Windows 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @GrahamcOfBorg @angerman