Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Make platform predicates greppable history fix #37464

Merged
merged 2 commits into from Mar 20, 2018
Merged

lib: Make platform predicates greppable history fix #37464

merged 2 commits into from Mar 20, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Nothing is changed, but this allows me to keep on making my lib changes 18.03-ready if we decide to back-port it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
lib: Make platform predicates greppable
175d4ab 
Should have commited on here and on merged master to begin with, but I
didn't, so instead I cherry-pick.

(cherry picked from commit 88c04a8)
@Ericson2314
Merge commit '543210751f46a4787fd0a5ef4c3bfa9a4b789e3c' into greppable
2ce3df3
@Ericson2314 Ericson2314 added the 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform label Mar 20, 2018
@Ericson2314 Ericson2314 merged commit 326c9f5 into NixOS:master Mar 20, 2018
@Ericson2314 Ericson2314 deleted the greppable branch March 20, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ericson2314