bitmath: init at 1.3.1.2 #37462

Twey · 2018-03-20T16:41:18Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

FRidh · 2018-03-20T17:37:58Z

pkgs/development/python-modules/bitmath/default.nix

+buildPythonPackage rec {
+  pname = "bitmath";
+  version = "1.3.1.2";
+  name = "${pname}-${version}";


The name attribute is added by buildPython* and should therefore be removed.

FRidh · 2018-03-20T17:38:27Z

pkgs/development/python-modules/bitmath/default.nix

+
+  meta = with stdenv.lib; {
+    description = ''
+      module for representing and manipulating file sizes with different prefix


Start with a capital letter. The part within parentheses can be dropped.

FRidh · 2018-03-20T17:38:46Z

pkgs/development/python-modules/bitmath/default.nix

+  };
+
+  doCheck = ! isPy36; # progressbar is incompatible with Py3?
+  buildInputs = if doCheck then [ progressbar mock ] else [ ];


checkInputs

FRidh · 2018-03-20T17:38:59Z

pkgs/development/python-modules/bitmath/default.nix

+    '';
+    homepage = "https://github.com/tbielawa/bitmath";
+    license = licenses.mit;
+    platforms = platforms.all;


should be dropped

Twey · 2018-03-20T21:51:46Z

Thanks!

Twey · 2018-03-21T11:04:59Z

Is this okay?

dotlambda · 2018-03-21T13:58:52Z

No, obviously not:
@GrahamcOfBorg build python3.pkgs.progressbar

GrahamcOfBorg · 2018-03-21T13:59:09Z

Failure on x86_64-linux (full log)

Attempted: python3.pkgs.progressbar

Partial log (click to expand)

    import progressbar
  File "/tmp/nix-build-python3.6-progressbar-2.3.drv-0/progressbar-2.3/progressbar/__init__.py", line 59, in <module>
    from progressbar.widgets import *
  File "/tmp/nix-build-python3.6-progressbar-2.3.drv-0/progressbar-2.3/progressbar/widgets.py", line 121, in <module>
    class FileTransferSpeed(Widget):
  File "/nix/store/b8gd0cbvkm59x8flbc53bvsvmskyig5a-python3-3.6.4/lib/python3.6/abc.py", line 133, in __new__
    cls = super().__new__(mcls, name, bases, namespace, **kwargs)
ValueError: 'format' in __slots__ conflicts with class variable
builder for ‘/nix/store/c7yfzf813yb515qsf8k3jfsm84bp869x-python3.6-progressbar-2.3.drv’ failed with exit code 1
error: build of ‘/nix/store/c7yfzf813yb515qsf8k3jfsm84bp869x-python3.6-progressbar-2.3.drv’ failed

GrahamcOfBorg · 2018-03-21T13:59:17Z

Failure on aarch64-linux (full log)

Attempted: python3.pkgs.progressbar

Partial log (click to expand)

    import progressbar
  File "/build/progressbar-2.3/progressbar/__init__.py", line 59, in <module>
    from progressbar.widgets import *
  File "/build/progressbar-2.3/progressbar/widgets.py", line 121, in <module>
    class FileTransferSpeed(Widget):
  File "/nix/store/143hazf8s5236kvprxlrgw9fdgzkrg0v-python3-3.6.4/lib/python3.6/abc.py", line 133, in __new__
    cls = super().__new__(mcls, name, bases, namespace, **kwargs)
ValueError: 'format' in __slots__ conflicts with class variable
builder for '/nix/store/nwh88rj5m2v184n7x34jx2va87vgcra9-python3.6-progressbar-2.3.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/nwh88rj5m2v184n7x34jx2va87vgcra9-python3.6-progressbar-2.3.drv' failed

FRidh · 2018-03-22T10:15:07Z

Seems like it should be disabled for Python 3.

dotlambda · 2018-03-22T10:28:08Z

But their setup.py explicitly mentions Python 3: https://github.com/niltonvolpato/python-progressbar/blob/master/setup.py#L50

Twey · 2018-03-22T12:30:43Z

It might just not support Python 3.6 — the last commit was a couple of years ago.
What's the conventional way to say ‘not on Python 3’?
EDIT: Never mind, disabled

Twey · 2018-03-22T15:03:59Z

Apparently it's a known problem. There's a fork with Python 3 support, but it doesn't seem to be on PyPI. There's also progressbar2, which I think is the correct way forward, but it's not quite API-compatible and requires patches to the bitmath test suite.

I've just disabled progressbar for Python 3 for now.

dotlambda · 2018-04-07T17:54:45Z

Sorry I forgot about this one.
Please remove the progressbar bump as it is included in #38483.
As soon as that PR is merged, you can rebase on staging and this can be merged.

dotlambda · 2018-04-07T17:55:24Z

pkgs/development/python-modules/bitmath/default.nix

+    sha256 = "1k8d1wmxqjc8cqzaixpxf45k6dl1kqhblr0g4wyjl0qa18q8wasd";
+  };
+
+  doCheck = ! isPy36; # progressbar is incompatible with Py3?


Not necessary because progressbar is now disabled on python3.

I believe it's still necessary, because this package's tests expect progressbar, so if it's disabled on Py3 the tests will fail.

It won't even be built on Python 3, so no tests will be run. Just rebase on staging and you'll see what I mean.

In fact it doesn't even get to failing the tests — it will try to load progressbar for checkInputs and immediately fail.

That's what I meant with "it won't be built". Please just remove that doCheck = false line.

I see. Looking at https://github.com/tbielawa/bitmath/blob/master/requirements.txt and https://github.com/tbielawa/bitmath/blob/master/requirements-py3.txt, it seems like progressbar231 is required for Python 2 and progressbar33 for Python 3. At least the latter should be packaged so that tests can be enabled for Python 3.
Btw, please use isPy3k instead of isPy36.

I must admit, I'm a bit confused about the difference between progressbar, progressbar231, and progressbar33. They seem to be just different versions of the same package? Their description text is exactly the same. Is this a Python convention I'm unaware of?

It's because progressbar has been abandoned by its maintainer. Other people created newer versions, which diverged from each other.

Well, I've packaged them up anyway. bitmath now tests with 3.6; thanks for the pointer!

Thanks a lot!

dotlambda · 2018-04-07T17:55:46Z

pkgs/development/python-modules/bitmath/default.nix

+    description = ''
+      Module for representing and manipulating file sizes with different prefix
+      notations
+    '';


Please use " and a single line.

The line is 94 characters long if I stuff it all onto a single line; is that okay?

It's okay for me. I don't think there's a general limit of 80 characters for nixpkgs.

dotlambda · 2018-04-07T17:55:55Z

pkgs/development/python-modules/bitmath/default.nix

+      Module for representing and manipulating file sizes with different prefix
+      notations
+    '';
+    homepage = "https://github.com/tbielawa/bitmath";


dotlambda · 2018-04-10T11:38:20Z

@GrahamcOfBorg build python2.pkgs.progressbar231 python2.pkgs.progressbar33 python3.pkgs.progressbar33 python2.pkgs.bitmath python3.pkgs.bitmath

GrahamcOfBorg · 2018-04-10T11:39:06Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.progressbar231, python2.pkgs.progressbar33, python3.pkgs.progressbar33, python2.pkgs.bitmath, python3.pkgs.bitmath

Partial log (click to expand)

query device capacity works on a happy Linux host ... ok
test_query_device_capacity_mac_everything_is_wonderful (tests.test_query_device_capacity.TestQueryDeviceCapacity)
query device capacity works on a happy Mac OS X host ... ok
test_query_device_capacity_non_posix_system_fails (tests.test_query_device_capacity.TestQueryDeviceCapacity)
query device capacity fails on a non-posix host ... ok

----------------------------------------------------------------------
Ran 211 tests in 0.025s

OK

GrahamcOfBorg · 2018-04-10T11:39:33Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.progressbar231, python2.pkgs.progressbar33, python3.pkgs.progressbar33, python2.pkgs.bitmath, python3.pkgs.bitmath

Partial log (click to expand)

listdir: symbolic links in tree are followed ... ok
test_listdir_symlinks_follow_relpath_false (tests.test_file_size.TestFileSize)
listdir: symlinks followed, absolute paths are returned ... ok
test_listdir_symlinks_nofollow (tests.test_file_size.TestFileSize)
listdir: symbolic links in tree not followed ... ok

----------------------------------------------------------------------
Ran 211 tests in 0.184s

OK

dotlambda · 2018-04-10T11:42:12Z

pkgs/development/python-modules/progressbar231/default.nix

+    inherit pname version;
+    sha256 = "0j0ifxk87xz3wkyacxaiqygghn27wwz6y5pj9k8j2yq7n33fbdam";
+  };
+


# no tests implemented doCheck = false;

dotlambda · 2018-04-10T11:42:20Z

pkgs/development/python-modules/progressbar33/default.nix

+    inherit pname version;
+    sha256 = "1zvf6zs5hzrc03p9nfs4p16vhilqikycvv1yk0pxn8s07fdhvzji";
+  };
+


# no tests implemented doCheck = false;

dotlambda · 2018-04-10T11:42:38Z

pkgs/top-level/python-packages.nix

@@ -11480,6 +11482,9 @@ in {

  progressbar2 = callPackage ../development/python-modules/progressbar2 { };

+  progressbar231 = callPackage ../development/python-modules/progressbar231 { };
+  progressbar33 = callPackage ../development/python-modules/progressbar33 { };


Please add an empty line.

Twey · 2018-04-10T11:49:49Z

Done!

dotlambda · 2018-04-10T12:13:55Z

Thanks a lot!

Twey requested a review from FRidh as a code owner March 20, 2018 16:41

Twey force-pushed the python-bitmath branch 3 times, most recently from 11fcde1 to 338453a Compare March 20, 2018 16:46

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 20, 2018

FRidh requested changes Mar 20, 2018

View reviewed changes

Twey force-pushed the python-bitmath branch from 338453a to 4891781 Compare March 20, 2018 21:51

dotlambda reviewed Apr 7, 2018

View reviewed changes

dotlambda changed the base branch from master to staging April 7, 2018 17:57

GrahamcOfBorg added the 2.status: merge conflict label Apr 7, 2018

Twey force-pushed the python-bitmath branch 2 times, most recently from 79e1db8 to f69d09b Compare April 10, 2018 10:33

GrahamcOfBorg removed the 2.status: merge conflict label Apr 10, 2018

Twey force-pushed the python-bitmath branch from f69d09b to 50faaa3 Compare April 10, 2018 11:33

dotlambda requested changes Apr 10, 2018

View reviewed changes

Twey added 3 commits April 10, 2018 12:47

pythonPackages.progressbar231: init at 2.3.1

8c6d838

pythonPackages.progressbar33: init at 2.4

10863b0

pythonPackages.bitmath: init at 1.3.1.2

0b919d4

Twey force-pushed the python-bitmath branch from 50faaa3 to 0b919d4 Compare April 10, 2018 11:49

dotlambda merged commit 1bf566e into NixOS:staging Apr 10, 2018

Twey deleted the python-bitmath branch April 10, 2018 13:24

bitmath: init at 1.3.1.2 #37462

bitmath: init at 1.3.1.2 #37462

Conversation

Twey commented Mar 20, 2018 • edited

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Twey commented Mar 20, 2018

Twey commented Mar 21, 2018

dotlambda commented Mar 21, 2018

GrahamcOfBorg commented Mar 21, 2018

GrahamcOfBorg commented Mar 21, 2018

FRidh commented Mar 22, 2018

dotlambda commented Mar 22, 2018

Twey commented Mar 22, 2018 • edited

Twey commented Mar 22, 2018

dotlambda commented Apr 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Twey Apr 10, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Apr 10, 2018

GrahamcOfBorg commented Apr 10, 2018

GrahamcOfBorg commented Apr 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Twey commented Apr 10, 2018

dotlambda commented Apr 10, 2018

Twey commented Mar 20, 2018 •

edited

Twey commented Mar 22, 2018 •

edited

Twey Apr 10, 2018 •

edited