Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todolist: init at 0.8 #37463

Merged
merged 1 commit into from Mar 21, 2018
Merged

todolist: init at 0.8 #37463

merged 1 commit into from Mar 21, 2018

Conversation

uvNikita
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

nlewo
nlewo requested changes Mar 20, 2018
View reviewed changes
pkgs/applications/misc/todolist/default.nix Outdated

goPackagePath = "github.com/gammons/todolist";

src = fetchgit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use fetchFromGitHub please?

@uvNikita
Copy link
Contributor Author

@nlewo Done. I also removed unnecessary rev attribute from buildGoPackage and moved it to fetchFromGitHub.

@nlewo
Copy link
Member

nlewo commented Mar 20, 2018

@uvNikita Thanks
@GrahamcOfBorg build todolist

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: todolist

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/yjbdkd5wpknn03w8rb3hihim9jj1kizd-todolist-0.8-bin/bin
patching script interpreter paths in /nix/store/yjbdkd5wpknn03w8rb3hihim9jj1kizd-todolist-0.8-bin
checking for references to /build in /nix/store/yjbdkd5wpknn03w8rb3hihim9jj1kizd-todolist-0.8-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/5gfw6vyxr7ff9148n671vk0l8k5ii0pj-todolist-0.8
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/5gfw6vyxr7ff9148n671vk0l8k5ii0pj-todolist-0.8
/nix/store/5gfw6vyxr7ff9148n671vk0l8k5ii0pj-todolist-0.8/share/go/src/github.com/gammons/todolist/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/5gfw6vyxr7ff9148n671vk0l8k5ii0pj-todolist-0.8/share/go/src/github.com/gammons/todolist/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/5gfw6vyxr7ff9148n671vk0l8k5ii0pj-todolist-0.8...
/nix/store/yjbdkd5wpknn03w8rb3hihim9jj1kizd-todolist-0.8-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: todolist

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/ahha2b130n7sqlhwblvqgggx3842qid8-todolist-0.8-bin/bin
patching script interpreter paths in /nix/store/ahha2b130n7sqlhwblvqgggx3842qid8-todolist-0.8-bin
checking for references to /build in /nix/store/ahha2b130n7sqlhwblvqgggx3842qid8-todolist-0.8-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/zpjkf1zqsn1snmpwyldyrsi7l8cbp02b-todolist-0.8
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/zpjkf1zqsn1snmpwyldyrsi7l8cbp02b-todolist-0.8
/nix/store/zpjkf1zqsn1snmpwyldyrsi7l8cbp02b-todolist-0.8/share/go/src/github.com/gammons/todolist/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/zpjkf1zqsn1snmpwyldyrsi7l8cbp02b-todolist-0.8/share/go/src/github.com/gammons/todolist/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/zpjkf1zqsn1snmpwyldyrsi7l8cbp02b-todolist-0.8...
/nix/store/ahha2b130n7sqlhwblvqgggx3842qid8-todolist-0.8-bin

@nlewo nlewo merged commit e5b98c8 into NixOS:master Mar 21, 2018
@uvNikita uvNikita deleted the add/todolist branch March 23, 2018 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uvNikita @nlewo @GrahamcOfBorg