Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

st: add dmenu dependency #37492

Merged
merged 1 commit into from Mar 22, 2018
Merged

st: add dmenu dependency #37492

merged 1 commit into from Mar 22, 2018

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Mar 20, 2018

Motivation for this change

This PR adds the dependency for dmenu to st which is used since 0.8 to insert unicode codepoints.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member

nlewo commented Mar 21, 2018

@viric @andsild could you have a look?
@geistesk did you try to had dmenu in the PATH of st with makeWrapper?

@oxzi
Copy link
Member Author

oxzi commented Mar 22, 2018

@nlewo I didn't know makeWrapper and this makes it a lot easier; thanks! I updated the PR.

@nlewo
Copy link
Member

nlewo commented Mar 22, 2018

@geistesk yes, much better like this. Could you update the commit message?

@oxzi oxzi changed the title st: dmenu-dependency and patch st: add dmenu dependency Mar 22, 2018
@oxzi
Copy link
Member Author

oxzi commented Mar 22, 2018

@nlewo like this?

@nlewo
Copy link
Member

nlewo commented Mar 22, 2018

@geistesk yes. Thanks.
@GrahamcOfBorg build st

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: st

Partial log (click to expand)

Please see the README file regarding the terminfo entry of st.
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/397cdzq5na4p62sw4qjzrdih83n6z6lk-st-0.8.1
shrinking /nix/store/397cdzq5na4p62sw4qjzrdih83n6z6lk-st-0.8.1/bin/.st-wrapped
gzipping man pages under /nix/store/397cdzq5na4p62sw4qjzrdih83n6z6lk-st-0.8.1/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/397cdzq5na4p62sw4qjzrdih83n6z6lk-st-0.8.1/bin
patching script interpreter paths in /nix/store/397cdzq5na4p62sw4qjzrdih83n6z6lk-st-0.8.1
checking for references to /build in /nix/store/397cdzq5na4p62sw4qjzrdih83n6z6lk-st-0.8.1...
/nix/store/397cdzq5na4p62sw4qjzrdih83n6z6lk-st-0.8.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: st

Partial log (click to expand)

Please see the README file regarding the terminfo entry of st.
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rh18j7l0w9vj4cg2qnzqfhqhhnnp0b6r-st-0.8.1
shrinking /nix/store/rh18j7l0w9vj4cg2qnzqfhqhhnnp0b6r-st-0.8.1/bin/.st-wrapped
gzipping man pages under /nix/store/rh18j7l0w9vj4cg2qnzqfhqhhnnp0b6r-st-0.8.1/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rh18j7l0w9vj4cg2qnzqfhqhhnnp0b6r-st-0.8.1/bin
patching script interpreter paths in /nix/store/rh18j7l0w9vj4cg2qnzqfhqhhnnp0b6r-st-0.8.1
checking for references to /build in /nix/store/rh18j7l0w9vj4cg2qnzqfhqhhnnp0b6r-st-0.8.1...
/nix/store/rh18j7l0w9vj4cg2qnzqfhqhhnnp0b6r-st-0.8.1

nlewo
nlewo requested changes Mar 22, 2018
View reviewed changes
pkgs/applications/misc/st/default.nix Outdated
nativeBuildInputs = [ pkgconfig ];
buildInputs = [ libX11 ncurses libXext libXft fontconfig ] ++ extraLibs;
nativeBuildInputs = [ pkgconfig makeWrapper ];
buildInputs = [ libX11 ncurses libXext libXft fontconfig dmenu ] ++ extraLibs;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf, sorry, one last thing... I think you don't need to add it in buildInputs since you add it in the PATH.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault, should be fixed now.

@nlewo
Copy link
Member

nlewo commented Mar 22, 2018

@geistesk thanks!

@nlewo nlewo merged commit 3dc8d5c into NixOS:master Mar 22, 2018
@oxzi oxzi deleted the st-dmenu branch March 22, 2018 11:44
@oxzi oxzi mentioned this pull request Nov 18, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxzi @nlewo @GrahamcOfBorg @aKriJcz