Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awscli: 1.14.47 -> 1.14.50 #37496

Merged
merged 1 commit into from Mar 21, 2018
Merged

awscli: 1.14.47 -> 1.14.50 #37496

merged 1 commit into from Mar 21, 2018

Conversation

spencerjanssen
Copy link
Contributor

@spencerjanssen spencerjanssen commented Mar 20, 2018 •
edited

Motivation for this change

Fixes a broken build introduced when botocore was updated in ce34a9a. 1.14.50 isn't the latest version but it is the version that was released with botocore 1.9.3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@spencerjanssen
awscli: 1.14.47 -> 1.14.50
3c64662 
Fixes a broken build introduced when botocore was updated in ce34a9a
@nlewo
Copy link
Member

nlewo commented Mar 21, 2018

@GrahamcOfBorg build awscli

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: awscli

Partial log (click to expand)

/build/awscli-1.14.50
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jdsnr5692vlvgh7pdkzlw7a20b55yf7i-awscli-1.14.50
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/jdsnr5692vlvgh7pdkzlw7a20b55yf7i-awscli-1.14.50/lib  /nix/store/jdsnr5692vlvgh7pdkzlw7a20b55yf7i-awscli-1.14.50/bin
patching script interpreter paths in /nix/store/jdsnr5692vlvgh7pdkzlw7a20b55yf7i-awscli-1.14.50
checking for references to /build in /nix/store/jdsnr5692vlvgh7pdkzlw7a20b55yf7i-awscli-1.14.50...
wrapping `/nix/store/jdsnr5692vlvgh7pdkzlw7a20b55yf7i-awscli-1.14.50/bin/aws'...
wrapping `/nix/store/jdsnr5692vlvgh7pdkzlw7a20b55yf7i-awscli-1.14.50/bin/aws_completer'...
/nix/store/jdsnr5692vlvgh7pdkzlw7a20b55yf7i-awscli-1.14.50

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: awscli

Partial log (click to expand)

Successfully installed awscli-1.14.50
/tmp/nix-build-awscli-1.14.50.drv-0/awscli-1.14.50
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2hm2nkciscqnbb4mjkp4lmi1ivgwqg7c-awscli-1.14.50
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2hm2nkciscqnbb4mjkp4lmi1ivgwqg7c-awscli-1.14.50/lib  /nix/store/2hm2nkciscqnbb4mjkp4lmi1ivgwqg7c-awscli-1.14.50/bin 
patching script interpreter paths in /nix/store/2hm2nkciscqnbb4mjkp4lmi1ivgwqg7c-awscli-1.14.50
checking for references to /tmp/nix-build-awscli-1.14.50.drv-0 in /nix/store/2hm2nkciscqnbb4mjkp4lmi1ivgwqg7c-awscli-1.14.50...
wrapping `/nix/store/2hm2nkciscqnbb4mjkp4lmi1ivgwqg7c-awscli-1.14.50/bin/aws'...
wrapping `/nix/store/2hm2nkciscqnbb4mjkp4lmi1ivgwqg7c-awscli-1.14.50/bin/aws_completer'...

@nlewo nlewo merged commit 8920d1e into NixOS:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spencerjanssen @nlewo @GrahamcOfBorg