Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toml: init at 0.9.4 #37469

Merged
merged 1 commit into from Mar 25, 2018
Merged

toml: init at 0.9.4 #37469

merged 1 commit into from Mar 25, 2018

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Mar 20, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Twey Twey requested a review from FRidh as a code owner March 20, 2018 17:08
FRidh
FRidh requested changes Mar 20, 2018
View reviewed changes
pkgs/development/python-modules/toml/default.nix Outdated
buildPythonPackage rec {
pname = "toml";
version = "0.9.4";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name attribute is added by buildPython* and should therefore be removed.

@FRidh
Copy link
Member

FRidh commented Mar 20, 2018

@GrahamcOfBorg build python.pkgs.toml python3.pkgs.toml

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python.pkgs.toml, python3.pkgs.toml

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'toml.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/x284lir9a4crd99fvkwarvn5li4khkfh-python2.7-toml-0.9.4
/nix/store/ri7a0h2a49d4agl0kk8cywqqmcnbfmcq-python3.6-toml-0.9.4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python.pkgs.toml, python3.pkgs.toml

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'toml.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/wml4cm5rx86wxbk74y6psxhmymrx8ry4-python2.7-toml-0.9.4
/nix/store/kciffc34ndnq8cdx5h94kwk0qp5zjxjx-python3.6-toml-0.9.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python.pkgs.toml, python3.pkgs.toml

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'toml.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/kninl7aphcd06d0a17f3klnri7hnpwj8-python2.7-toml-0.9.4
/nix/store/ira27zgkd0sn6f99hmxyfsmbd0qndkwy-python3.6-toml-0.9.4

@FRidh
Copy link
Member

FRidh commented Mar 20, 2018 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

FRidh
FRidh reviewed Mar 20, 2018
View reviewed changes
pkgs/development/python-modules/toml/default.nix Outdated
description = "a Python library for parsing and creating TOML";
homepage = "https://github.com/uiri/toml";
license = licenses.mit;
platforms = platforms.all;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed

@Twey
Copy link
Contributor Author

Twey commented Mar 20, 2018

Thanks!

There is a test suite but it's not very Nix-friendly. I've disabled it for the time being. Maybe we could add separate packages for tox and toml-test and make a tester that runs it that way.

@matthewbauer matthewbauer merged commit 2e02bca into NixOS:master Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Twey @FRidh @GrahamcOfBorg @matthewbauer