krunner-pass: init at version v1.3.0 #37494
Conversation
| fetchFromGitHub, | ||
| cmake, extra-cmake-modules, gnumake, | ||
|
|
||
| pass, pass-otp ? null, krunner, |
There was a problem hiding this comment.
Why pass-otp is optional? It seems to me this is not necessary
There was a problem hiding this comment.
Judging by it's readme it can optionally be used with pass-otp hence the optional dependency.
| }: | ||
| let | ||
| pname = "krunner-pass"; | ||
| version = "v1.3.0"; |
There was a problem hiding this comment.
The version in the package name should only contain digits (nixpkgs coding conventions).
| src = fetchFromGitHub { | ||
| owner = "akermu"; | ||
| repo = "krunner-pass"; | ||
| rev = "a541cf126689fa27665248aa1d7f934fc551a0c7"; |
There was a problem hiding this comment.
You can use the version number as a git tag.
| sha256 = "032fs2174ls545kjixbhzyd65wgxkw4s5vg8b20irc5c9ak3pxm0"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ |
There was a problem hiding this comment.
These build inputs should not need to be propagated.
Please change propagatedBuildInputs to buildInputs.
| src = fetchFromGitHub { | ||
| owner = "akermu"; | ||
| repo = "krunner-pass"; | ||
| rev = "v1.3.0"; |
There was a problem hiding this comment.
rev = "v1.3.0"; -> rev = "v${version}";
|
I see that A simple example of how it should be done can be found here. |
|
@adisbladis It is the recommended way? Because It would be more robust (not source code dependent) to set the |
|
@nlewo It depends :) In this case there are no binaries expected to be invoked by a user in the output, there are only some shared objects that are loaded by krunner so the |
|
@adisbladis ah yes, I didn't see no binaries are produced, sorry. |
|
applied requested changes, hope that I did the patch alright. |
krunner looks for a |
adisbladis
force-pushed
the
new/krunner-pass
branch
from
8b45250
to
0c95dee
Compare
Motivation for this change
accessing passwords through krunner
Things done
build-use-sandboxinnix.confon non-NixOS)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)Tested compilation of all pkgs that depend on this change usingnix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually in./result/bin/)P.S. I'm not entirely sure if I located this at the right place.. I'm very open for comments as this is also my first commit to nixpkgs :)