mdv: init at 1.6.3 #37495

Synthetica9 · 2018-03-20T22:01:13Z

Motivation for this change

mvd wasn't in packages.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda

Please prefix your commit message with pythonPackages.

dotlambda · 2018-03-21T09:06:48Z

pkgs/top-level/python-packages.nix

+      homepage = https://github.com/axiros/terminal_markdown_viewer;
+      description = "Terminal Markdown Viewer";
+      license = licenses.bsd;
+      maintainers = with maintainers; [ synthetica ];


You need to add yourself to https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix.

dotlambda · 2018-03-21T09:07:02Z

pkgs/top-level/python-packages.nix

@@ -20204,6 +20204,26 @@ EOF

  pypandoc = callPackage ../development/python-modules/pypandoc { };

+  mdv = buildPythonPackage rec {


Please use callPackage.

dotlambda · 2018-03-21T09:07:13Z

pkgs/top-level/python-packages.nix

@@ -20204,6 +20204,26 @@ EOF

  pypandoc = callPackage ../development/python-modules/pypandoc { };

+  mdv = buildPythonPackage rec {
+    pname = "mdv";
+    name = "${pname}-${version}";


Leave this line out.

dotlambda · 2018-03-21T09:07:23Z

pkgs/top-level/python-packages.nix

+    name = "${pname}-${version}";
+    version = "1.6.3";
+
+    src = pkgs.fetchurl {


fetchPypi

Synthetica9 · 2018-03-21T14:44:46Z

@dotlambda Bump

dotlambda · 2018-03-21T15:26:09Z

@GrahamcOfBorg build python2.pkgs.mdv python3.pkgs.mdv

GrahamcOfBorg · 2018-03-21T15:26:43Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.mdv, python3.pkgs.mdv

Partial log (click to expand)

writing manifest file 'mdv.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
!! Could not derive your terminal width !!
/nix/store/y6ssnyd9xfs48maaqn9y3wz6z06x25jr-python2.7-mdv-1.6.3
/nix/store/p2lx7g32z8slwb86vakxy7920sp84qj8-python3.6-mdv-1.6.3

GrahamcOfBorg · 2018-03-21T15:27:59Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.mdv, python3.pkgs.mdv

Partial log (click to expand)

writing manifest file 'mdv.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
!! Could not derive your terminal width !!
/nix/store/5lc2xjcz7xm4cgqymcsqy8j63b2a7b4f-python2.7-mdv-1.6.3
/nix/store/bfgv77gfa559m3gczgg44l5bl0mgq1y7-python3.6-mdv-1.6.3

dotlambda · 2018-03-21T15:30:04Z

Ran 0 tests in 0.000s

Please provide the correct checkPhase.

Also, note https://github.com/axiros/terminal_markdown_viewer#manual-install-requirements (disabled = isPy3k).

aanderse · 2019-05-22T00:01:46Z

@Synthetica9 are you able to continue with this PR?

FRidh · 2019-07-20T11:32:46Z

Nothing happening so closing.

Synthetica9 requested a review from FRidh as a code owner March 20, 2018 22:01

GrahamcOfBorg added the 6.topic: python label Mar 20, 2018

dotlambda requested changes Mar 21, 2018

View reviewed changes

Synthetica9 added 2 commits March 21, 2018 15:41

pythonPackages-mdv: init at 1.6.3

b4010ba

Added myself to mainters-list.nix

03add39

Synthetica9 force-pushed the mdv-init branch from 5406ec7 to 03add39 Compare March 21, 2018 14:43

Fixed license

7162e19

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 21, 2018

samueldr added the 2.status: merge conflict label Nov 11, 2018

FRidh closed this Jul 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mdv: init at 1.6.3 #37495

mdv: init at 1.6.3 #37495

Synthetica9 commented Mar 20, 2018

dotlambda left a comment

dotlambda Mar 21, 2018

dotlambda Mar 21, 2018

dotlambda Mar 21, 2018

dotlambda Mar 21, 2018

Synthetica9 commented Mar 21, 2018

dotlambda commented Mar 21, 2018

GrahamcOfBorg commented Mar 21, 2018

GrahamcOfBorg commented Mar 21, 2018

dotlambda commented Mar 21, 2018

aanderse commented May 22, 2019

FRidh commented Jul 20, 2019 •

edited

		@@ -20204,6 +20204,26 @@ EOF

		pypandoc = callPackage ../development/python-modules/pypandoc { };

		mdv = buildPythonPackage rec {

mdv: init at 1.6.3 #37495

mdv: init at 1.6.3 #37495

Conversation

Synthetica9 commented Mar 20, 2018

Motivation for this change

Things done

dotlambda left a comment

Choose a reason for hiding this comment

dotlambda Mar 21, 2018

Choose a reason for hiding this comment

dotlambda Mar 21, 2018

Choose a reason for hiding this comment

dotlambda Mar 21, 2018

Choose a reason for hiding this comment

dotlambda Mar 21, 2018

Choose a reason for hiding this comment

Synthetica9 commented Mar 21, 2018

dotlambda commented Mar 21, 2018

GrahamcOfBorg commented Mar 21, 2018

GrahamcOfBorg commented Mar 21, 2018

dotlambda commented Mar 21, 2018

aanderse commented May 22, 2019

FRidh commented Jul 20, 2019 • edited

FRidh commented Jul 20, 2019 •

edited