Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samtools: make gcc dependency explicit #37182

Merged
merged 1 commit into from Mar 18, 2018
Merged

samtools: make gcc dependency explicit #37182

merged 1 commit into from Mar 18, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Mar 16, 2018 •
edited

Motivation for this change

/cc ZHF #36454 (failing on master)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Mar 18, 2018

@GrahamcOfBorg build samtools_0_1_19

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: samtools_0_1_19

Partial log (click to expand)

these paths will be fetched (0.16 MiB download, 0.39 MiB unpacked):
  /nix/store/zm1x7p0x7isxils1xx4vbi2yyhvf1faz-samtools-0.1.19
copying path '/nix/store/zm1x7p0x7isxils1xx4vbi2yyhvf1faz-samtools-0.1.19' from 'https://cache.nixos.org'...
/nix/store/zm1x7p0x7isxils1xx4vbi2yyhvf1faz-samtools-0.1.19

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: samtools_0_1_19

Partial log (click to expand)

gcc -g -Wall -O2 -c -I.. -o bamcheck.o bamcheck.c
gcc -g -Wall -O2 -o bamcheck bamcheck.o -L.. -lm -lbam -lpthread -lz
make[1]: Leaving directory '/private/tmp/nix-build-samtools-0.1.19.drv-0/samtools-0.1.19/misc'
installing
post-installation fixup
gzipping man pages under /nix/store/6ghxhilhadl4xh1i5pc47vir5dyr7b3x-samtools-0.1.19/share/man/
strip is /nix/store/7yql2shjp9v78d5s6p264367np5zbl35-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/6ghxhilhadl4xh1i5pc47vir5dyr7b3x-samtools-0.1.19/bin
patching script interpreter paths in /nix/store/6ghxhilhadl4xh1i5pc47vir5dyr7b3x-samtools-0.1.19
/nix/store/6ghxhilhadl4xh1i5pc47vir5dyr7b3x-samtools-0.1.19

@LnL7 LnL7 merged commit 3b52f78 into NixOS:master Mar 18, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: samtools_0_1_19

Partial log (click to expand)

these paths will be fetched (0.18 MiB download, 0.43 MiB unpacked):
  /nix/store/smfbgy94cchhsgd66mxsdhmynla4vnz8-samtools-0.1.19
copying path '/nix/store/smfbgy94cchhsgd66mxsdhmynla4vnz8-samtools-0.1.19' from 'https://cache.nixos.org'...
/nix/store/smfbgy94cchhsgd66mxsdhmynla4vnz8-samtools-0.1.19

@mbode mbode deleted the samtools_gcc branch April 3, 2018 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbode @LnL7 @GrahamcOfBorg