Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pathname#glob #5105

Merged
merged 2 commits into from Mar 23, 2018
Merged

Add Pathname#glob #5105

merged 2 commits into from Mar 23, 2018

Conversation

nomadium
Copy link
Contributor

Hi folks,

I opened another PR to complete the work on #5095 since I can't push to that branch.

All Pathname tests should pass now.

/cc: #4876

Thanks,

headius and others added 2 commits March 22, 2018 19:29
@headius @nomadium
Add Pathname#glob based on CRuby.
09e23c3 
This does not yet pass MRI Pathname#glob test.
@nomadium
Update Pathname#glob implementation to pass MRI tests
37a70b6 
For more information, please see feature jruby#7360.
@nomadium nomadium mentioned this pull request Mar 22, 2018
Closed
@kares kares added this to the JRuby 9.2.0.0 milestone Mar 23, 2018
@kares kares merged commit b3ac23c into jruby:ruby-2.5 Mar 23, 2018
@nomadium nomadium deleted the add-pathname-glob-take-2 branch March 23, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core ruby 2.5
Projects
None yet
Milestone
JRuby 9.2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nomadium @kares @headius