Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechat: Add plugin to config only if it is used #37622

Closed
wants to merge 2 commits into from
Closed

weechat: Add plugin to config only if it is used #37622

wants to merge 2 commits into from

Conversation

expipiplus1
Copy link
Contributor

Previously it wasn't possible to build weechat without python support as
the weechat.python attribute was used in the config'

@expipiplus1
weechat: Add plugin to config only if it is used
a46dc17 
Previously it wasn't possible to build weechat without python support as
the `weechat.python` attribute was used in the config'
@expipiplus1 expipiplus1 mentioned this pull request Mar 22, 2018
Closed
@srhb
Copy link
Contributor

srhb commented Apr 27, 2018

@lheckemann Care to review?

@lheckemann
Copy link
Member

👍 overall but this could be done a lot more simply using lib.intersectAttrs enabledPlugins {python = …; perl = …;} rather than the chain of optionalAttrs {…} //.

@bdesham bdesham mentioned this pull request Aug 1, 2019
Merged
10 tasks
@veprbl veprbl closed this in #64262 Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@expipiplus1 @srhb @lheckemann @ryantm @GrahamcOfBorg