Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xpdf: Don't try to wrap xpdf binary on Darwin if it wasn't requested (enableGUI = false) #37637

Merged
merged 1 commit into from Mar 26, 2018
Merged

xpdf: Don't try to wrap xpdf binary on Darwin if it wasn't requested (enableGUI = false) #37637

merged 1 commit into from Mar 26, 2018

Conversation

alexvorobiev
Copy link
Contributor

Motivation for this change

The postInstall clause wants to wrap xpdf on Darwin even if it was't built (enableGUI = false)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Mar 26, 2018

@GrahamcOfBorg build xpdf

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: xpdf

Partial log (click to expand)

these paths will be fetched (1.52 MiB download, 15.75 MiB unpacked):
  /nix/store/ja766lgasw8kfc2p24m7a22rgjgf7hjr-xpdf-4.00
copying path '/nix/store/ja766lgasw8kfc2p24m7a22rgjgf7hjr-xpdf-4.00' from 'https://cache.nixos.org'...
/nix/store/ja766lgasw8kfc2p24m7a22rgjgf7hjr-xpdf-4.00

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xpdf

Partial log (click to expand)

these paths will be fetched (1.58 MiB download, 17.35 MiB unpacked):
  /nix/store/myaz9nlr161h2mxzra773knav6078a1r-xpdf-4.00
copying path '/nix/store/myaz9nlr161h2mxzra773knav6078a1r-xpdf-4.00' from 'https://cache.nixos.org'...
/nix/store/myaz9nlr161h2mxzra773knav6078a1r-xpdf-4.00

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xpdf

Partial log (click to expand)

these paths will be fetched (1.53 MiB download, 17.73 MiB unpacked):
  /nix/store/fxqgn9y3mx6d5pqb20y3di0wd3n95760-xpdf-4.00
copying path '/nix/store/fxqgn9y3mx6d5pqb20y3di0wd3n95760-xpdf-4.00' from 'https://cache.nixos.org'...
/nix/store/fxqgn9y3mx6d5pqb20y3di0wd3n95760-xpdf-4.00

@LnL7 LnL7 merged commit adaa9d9 into NixOS:master Mar 26, 2018
@alexvorobiev alexvorobiev deleted the alexvorobiev-xpdf-darwin branch March 28, 2018 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexvorobiev @LnL7 @GrahamcOfBorg