Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.notebook: fix tests #37620

Merged
merged 1 commit into from Mar 22, 2018
Merged

python2Packages.notebook: fix tests #37620

merged 1 commit into from Mar 22, 2018

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Mar 22, 2018 •
edited

These were accidentally broken by #37615.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vaibhavsagar
python2Packages.notebook: fix tests
cafd433 
These were accidentally broken by NixOS#37615.
@vaibhavsagar vaibhavsagar mentioned this pull request Mar 22, 2018
Merged
8 tasks
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.notebook python3.pkgs.notebook

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.notebook, python3.pkgs.notebook

Partial log (click to expand)

/nix/store/s6asrspp3x0qgcqhq96fdbbdh0qk2395-python2.7-notebook-5.4.1
/nix/store/mk8z292fn7lg2lq7vqzzwfq1rvhiqi7w-python3.6-notebook-5.4.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.notebook, python3.pkgs.notebook

Partial log (click to expand)

/nix/store/9mknsvj39gr49cbpzqd9m7q1x6fvpi8z-python2.7-notebook-5.4.1
/nix/store/x4nb1b60v81hqpg3377x49nz2kwasbjs-python3.6-notebook-5.4.1

@dotlambda dotlambda merged commit ad4c5c1 into NixOS:master Mar 22, 2018
@vaibhavsagar
Copy link
Member Author

Thanks again!

@vaibhavsagar vaibhavsagar deleted the fix-python2Packages-notebook branch March 22, 2018 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavsagar @dotlambda @GrahamcOfBorg