Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: eda804767026
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f4f3e19eac85
Choose a head ref
  • 4 commits
  • 3 files changed
  • 3 contributors

Commits on Mar 20, 2018

  1. browserpass: 2.0.11 -> 2.0.13

    (cherry picked from commit 82f2c19)
    tadfisher authored and ysndr committed Mar 20, 2018
    Copy the full SHA
    b0bb3a4 View commit details

Commits on Mar 22, 2018

  1. xcodeenv: replace deprecated package application procedure by the new…

    … export archive operation
    
    (cherry picked from commit f2bd9d4)
    svanderburg committed Mar 22, 2018
    Copy the full SHA
    275db7c View commit details
  2. Merge pull request #37503 from ysndr/update/browserpass

    (17.09) browserpass: 2.0.11 -> 2.0.13
    dotlambda authored Mar 22, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    7041212 View commit details
  3. xcodeenv: publish xcarchive directory in the output store path if req…

    …uested
    
    (cherry picked from commit 112ebed)
    svanderburg committed Mar 22, 2018

    Verified

    This commit was signed with the committer’s verified signature.
    Mic92 Jörg Thalheim
    Copy the full SHA
    f4f3e19 View commit details
Showing with 41 additions and 6 deletions.
  1. +30 −4 pkgs/development/mobile/xcodeenv/build-app.nix
  2. +2 −2 pkgs/tools/security/browserpass/default.nix
  3. +9 −0 pkgs/tools/security/browserpass/deps.nix
34 changes: 30 additions & 4 deletions pkgs/development/mobile/xcodeenv/build-app.nix
Original file line number Diff line number Diff line change
@@ -12,6 +12,7 @@
, certificateFile ? null
, certificatePassword ? null
, provisioningProfile ? null
, signMethod ? null
, generateIPA ? false
, generateXCArchive ? false
, enableWirelessDistribution ? false
@@ -21,7 +22,7 @@
, title ? null
}:

assert release -> codeSignIdentity != null && certificateFile != null && certificatePassword != null && provisioningProfile != null;
assert release -> codeSignIdentity != null && certificateFile != null && certificatePassword != null && provisioningProfile != null && signMethod != null;
assert enableWirelessDistribution -> installURL != null && bundleId != null && version != null && title != null;

let
@@ -82,13 +83,34 @@ stdenv.mkDerivation {
# Do the building
export LD=clang # To avoid problem with -isysroot parameter that is unrecognized by the stock ld. Comparison with an impure build shows that it uses clang instead. Ugly, but it works
xcodebuild -target ${_target} -configuration ${_configuration} ${stdenv.lib.optionalString (scheme != null) "-scheme ${scheme}"} -sdk ${_sdk} TARGETED_DEVICE_FAMILY="1, 2" ONLY_ACTIVE_ARCH=NO CONFIGURATION_TEMP_DIR=$TMPDIR CONFIGURATION_BUILD_DIR=$out ${if generateXCArchive then "archive" else ""} ${xcodeFlags} ${if release then ''"CODE_SIGN_IDENTITY=${codeSignIdentity}" PROVISIONING_PROFILE=$PROVISIONING_PROFILE OTHER_CODE_SIGN_FLAGS="--keychain $HOME/Library/Keychains/$keychainName-db"'' else ""}
xcodebuild -target ${_target} -configuration ${_configuration} ${stdenv.lib.optionalString (scheme != null) "-scheme ${scheme}"} -sdk ${_sdk} TARGETED_DEVICE_FAMILY="1, 2" ONLY_ACTIVE_ARCH=NO CONFIGURATION_TEMP_DIR=$TMPDIR CONFIGURATION_BUILD_DIR=$out ${if generateIPA || generateXCArchive then "-archivePath \"${name}.xcarchive\" archive" else ""} ${if release then ''PROVISIONING_PROFILE=$PROVISIONING_PROFILE OTHER_CODE_SIGN_FLAGS="--keychain $HOME/Library/Keychains/$keychainName-db"'' else ""} ${xcodeFlags}
${stdenv.lib.optionalString release ''
${stdenv.lib.optionalString generateIPA ''
# Create export plist file
cat > "${name}.plist" <<EOF
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>provisioningProfiles</key>
<dict>
<key>${bundleId}</key>
<string>$PROVISIONING_PROFILE</string>
</dict>
<key>method</key>
<string>${signMethod}</string>
${stdenv.lib.optionalString (signMethod == "enterprise" || signMethod == "ad-hoc") ''
<key>compileBitcode</key>
<false/>
''}
</dict>
</plist>
EOF
# Produce an IPA file
xcrun -sdk iphoneos PackageApplication -v $out/*.app -o "$out/${name}.ipa"
xcodebuild -exportArchive -archivePath "${name}.xcarchive" -exportOptionsPlist "${name}.plist" -exportPath $out
# Add IPA to Hydra build products
mkdir -p $out/nix-support
echo "file binary-dist \"$(echo $out/*.ipa)\"" > $out/nix-support/hydra-build-products
@@ -99,6 +121,10 @@ stdenv.mkDerivation {
echo "doc install \"$out/$appname.html\"" >> $out/nix-support/hydra-build-products
''}
''}
${stdenv.lib.optionalString generateXCArchive ''
mkdir -p $out
mv "${name}.xcarchive" $out
''}
# Delete our temp keychain
${deleteKeychain}
4 changes: 2 additions & 2 deletions pkgs/tools/security/browserpass/default.nix
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@

buildGoPackage rec {
name = "browserpass-${version}";
version = "2.0.7";
version = "2.0.13";

goPackagePath = "github.com/dannyvankooten/browserpass";

@@ -13,7 +13,7 @@ buildGoPackage rec {
repo = "browserpass";
owner = "dannyvankooten";
rev = version;
sha256 = "1dbp5za5qh6xmgh3w2cx5fbw13mh1szgj2y7ilmq0jh2ik09fbnd";
sha256 = "0pch0jddphgaaw208ddqjhnkiy5916n0kjxfza1cpc78fa8zw82l";
};

postInstall = ''
9 changes: 9 additions & 0 deletions pkgs/tools/security/browserpass/deps.nix
Original file line number Diff line number Diff line change
@@ -18,6 +18,15 @@
sha256 = "1qc502an4q3wgvrd9zw6zprgm28d90d2f98bdamdf4js03jj22xn";
};
}
{
goPackagePath = "github.com/sahilm/fuzzy";
fetch = {
type = "git";
url = "https://github.com/sahilm/fuzzy";
rev = "a154b19bb758dcdd6ede58dc11ea53c2950527b2";
sha256 = "0jkw6474d5ik2fq2zznqxj4y3p42z47r7mbg856ln5wyara2sg0l";
};
}
{
goPackagePath = "rsc.io/qr";
fetch = {