Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinch zoom doesn't work on android #20387

Closed
jdm opened this issue Mar 22, 2018 · 5 comments
Closed

Pinch zoom doesn't work on android #20387

jdm opened this issue Mar 22, 2018 · 5 comments
Assignees
@mbrubeck
Labels
A-embedding A-input P-android Android devices
Projects
Android MVP

Comments

@jdm
Copy link
Member

jdm commented Mar 22, 2018

No description provided.

@jdm jdm added this to To do in Android MVP via automation Mar 22, 2018
@fabricedesre
Copy link
Contributor

related: issue #20109

@paulrouget
Copy link
Contributor

I'm under the impression that we never send the ScrollZoomEvent.magnification to WR. So Pinch zoom is no-op.

We do support zooming via IOCompositor.page_zoom, but that's a different story.

@paulrouget
Copy link
Contributor

Yeah, txn.set_pinch_zoom is missing in compositor.rs.

@paulrouget
Copy link
Contributor

I'll be working on supporting pinch to zoom on my Android port. So I will eventually work on that soon if nobody takes care of it first.

Note: set_pinch_zoom doesn't appear to be enough. It only works while the page is loading. swap_buffer is not called I believe.

@mbrubeck mbrubeck self-assigned this May 4, 2018
@mbrubeck mbrubeck mentioned this issue May 4, 2018
Merged
bors-servo pushed a commit that referenced this issue May 24, 2018
Auto merge of #20749 - mbrubeck:pinch, r=glennw
1845e94 
Basic pinch zoom handling

r? glennw

Basic fix for #20387 and #20109.  Note: Without calling `generate_frame`
when updating Webrender's pinch zoom level, rendering doesn't happen
reliably during/after a pinch zoom gesture.  I'm not sure whether this
is the correct way to fix that or not.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20749)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue May 24, 2018
Auto merge of #20749 - mbrubeck:pinch, r=glennw
6ad085b 
Basic pinch zoom handling

r? glennw

Basic fix for #20387 and #20109.  Note: Without calling `generate_frame`
when updating Webrender's pinch zoom level, rendering doesn't happen
reliably during/after a pinch zoom gesture.  I'm not sure whether this
is the correct way to fix that or not.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20749)
<!-- Reviewable:end -->
@jdm
Copy link
Member Author

jdm commented Jul 23, 2018

Fixed by #20749.

@jdm jdm closed this as completed Jul 23, 2018
Android MVP automation moved this from To do to Done Jul 23, 2018
@atouchet atouchet mentioned this issue Aug 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbrubeck mbrubeck

Labels
A-embedding A-input P-android Android devices
Projects
Android
Status: Done
Android MVP
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mbrubeck @jdm @paulrouget @fabricedesre