treewide: get rid of platforms.allBut #36985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
commented
Mar 14, 2018
| @@ -18,7 +18,7 @@ stdenv.mkDerivation rec { | |||
| description = "Binary decision diagram package"; | |||
| license = "as-is"; | |||
|
|
|||
| platforms = with stdenv.lib.platforms; allBut cygwin; | |||
| platforms = stdenv.lib.platforms.unix; # Once had cygwin problems | |||
There was a problem hiding this comment.
unix is actually exactly allBut cygwin today, but comment is still good because cygwin probably should be considered Unix and Windows.
Ericson2314
commented
Mar 14, 2018
| @@ -29,7 +29,7 @@ stdenv.mkDerivation rec { | |||
| description = "Numix icon theme (square version)"; | |||
| homepage = https://numixproject.org; | |||
| license = licenses.gpl3; | |||
| platforms = with platforms; allBut darwin; | |||
| platforms = platforms.linux; # Maybe other non-darwin Unix | |||
There was a problem hiding this comment.
Concretely this now is claimed not work on the BSDs, but that stdenv has bitrotted anyways.
shlevy
approved these changes
Mar 14, 2018
globin
approved these changes
Mar 14, 2018
| @@ -37,7 +37,9 @@ stdenv.mkDerivation rec { | |||
| description = "A GTK2 image viewer, manga reader, and booru browser"; | |||
| maintainers = with maintainers; [ skrzyp xzfc ]; | |||
| license = licenses.mit; | |||
| platforms = platforms.allBut [ "darwin" "cygwin" ]; | |||
| # Unintentionally not working on Darwin: | |||
| # https://github.com/ahodesuka/ahoviewer/issues/63 | |||
There was a problem hiding this comment.
ahodesuka/ahoviewer#62 wow I incremented it somehow?
Negative reasoning like `allBut` is a bad idea with an open world of platforms. Concretely, if we add a new, quite different sort of platform, existing packages with `allBut` will claim they work on it even though they probably won't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Negative reasoning like
allButis a bad idea with an open world of platforms. Concretely, if we add a new, quite different sort of platform, existing packages withallButwill claim they work on it even though they probably won't.Also, there's no good/cheap way to implement this with a #34444 strategy.
allis also bad, but at least as a good constructive interpretation of "I work everywhere because I require nothing; so give me nothing". Relatedly, everything we have left can be expressed with horn clauses,allButcouldn't be.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)