Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stabber: init at 2016-11-09 #36988

Merged
merged 2 commits into from Mar 20, 2018
Merged

stabber: init at 2016-11-09 #36988

merged 2 commits into from Mar 20, 2018

Conversation

hschaeidt
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mpickering mpickering mentioned this pull request Mar 14, 2018
Merged
8 tasks
@ryantm
Copy link
Member

ryantm commented Mar 15, 2018

@GrahamcOfBorg build stabber

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: stabber

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/czasiwclw4y5jfdvwcshxlmsvgiba8bj-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4
shrinking /nix/store/czasiwclw4y5jfdvwcshxlmsvgiba8bj-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/bin/stabber
shrinking /nix/store/czasiwclw4y5jfdvwcshxlmsvgiba8bj-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/lib/libstabber.so.0.0.0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/czasiwclw4y5jfdvwcshxlmsvgiba8bj-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/lib  /nix/store/czasiwclw4y5jfdvwcshxlmsvgiba8bj-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/bin 
patching script interpreter paths in /nix/store/czasiwclw4y5jfdvwcshxlmsvgiba8bj-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4
checking for references to /tmp/nix-build-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4.drv-0 in /nix/store/czasiwclw4y5jfdvwcshxlmsvgiba8bj-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4...
/nix/store/czasiwclw4y5jfdvwcshxlmsvgiba8bj-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: stabber

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zhk5z3swb4lkc66cchrmbr6mx825pb0r-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4
shrinking /nix/store/zhk5z3swb4lkc66cchrmbr6mx825pb0r-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/bin/stabber
shrinking /nix/store/zhk5z3swb4lkc66cchrmbr6mx825pb0r-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/lib/libstabber.so.0.0.0
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/zhk5z3swb4lkc66cchrmbr6mx825pb0r-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/lib  /nix/store/zhk5z3swb4lkc66cchrmbr6mx825pb0r-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/bin
patching script interpreter paths in /nix/store/zhk5z3swb4lkc66cchrmbr6mx825pb0r-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4
checking for references to /build in /nix/store/zhk5z3swb4lkc66cchrmbr6mx825pb0r-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4...
/nix/store/zhk5z3swb4lkc66cchrmbr6mx825pb0r-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: stabber

Partial log (click to expand)

libtool: install: /nix/store/6b3jzg40vibmrjg85i46vvidyy915428-coreutils-8.29/bin/install -c .libs/stabber /nix/store/glbpcxnzxz78i87c49jkxpi74ka8chwc-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/bin/stabber
 /nix/store/6b3jzg40vibmrjg85i46vvidyy915428-coreutils-8.29/bin/mkdir -p '/nix/store/glbpcxnzxz78i87c49jkxpi74ka8chwc-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/include'
 /nix/store/6b3jzg40vibmrjg85i46vvidyy915428-coreutils-8.29/bin/install -c -m 644 stabber.h '/nix/store/glbpcxnzxz78i87c49jkxpi74ka8chwc-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/include'
make[1]: Leaving directory '/private/tmp/nix-build-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4.drv-0/source'
glibPreFixupPhase
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/glbpcxnzxz78i87c49jkxpi74ka8chwc-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/lib  /nix/store/glbpcxnzxz78i87c49jkxpi74ka8chwc-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4/bin
patching script interpreter paths in /nix/store/glbpcxnzxz78i87c49jkxpi74ka8chwc-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4
/nix/store/glbpcxnzxz78i87c49jkxpi74ka8chwc-stabber-ed75087e4483233eb2cc5472dbd85ddfb7a1d4d4

nlewo
nlewo requested changes Mar 17, 2018
View reviewed changes
pkgs/misc/stabber/default.nix Outdated
with stdenv.lib;

stdenv.mkDerivation rec {
name = "stabber-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use the commit date as package version (instead of the commit ID)?
This is mainly to be able to sort packages by their versions.
https://nixos.org/nixpkgs/manual/#sec-package-naming

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, thanks for the hint. i haven't seen that part in the manual yet.
package is updated.

@hschaeidt hschaeidt changed the title stabber: init at 2017-11-09 stabber: init at 2016-11-09 Mar 19, 2018
@nlewo
Copy link
Member

nlewo commented Mar 20, 2018

Thanks!

@nlewo nlewo merged commit ba96a90 into NixOS:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hschaeidt @ryantm @GrahamcOfBorg @nlewo