Add addIncludeDir to TestStep + fix build template #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
reviewed
Mar 14, 2018
std/build.zig
Outdated
| @@ -1648,6 +1648,10 @@ pub const TestStep = struct { | |||
| self.verbose = value; | |||
| } | |||
|
|
|||
| pub fn addIncludeDir(self: &TestStep, path: []const u8) void { | |||
| self.builder.include_paths.append(path) catch unreachable; | |||
There was a problem hiding this comment.
This does fix the issue, but it adds the include directory globally. I think it should add the directory for only this build artifact.
|
It would be good to merge this before the 0.2.0 to fix the default build template else any new user would encounter an error there. |
|
Oops, I'm so sorry. I saw this just after creating the tag. |
|
This looks good. I'm going to add a test to |
|
Merged. Thanks! I'm thinking maybe in the future instead of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #794.