Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QGIS and GRASS fixes #38916

Merged
merged 5 commits into from Apr 14, 2018
Merged

QGIS and GRASS fixes #38916

merged 5 commits into from Apr 14, 2018

Conversation

mpickering
Copy link
Contributor

Motivation for this change

Plugins and in particular the GRASS plugin were broken on darwin. These subtle changes fix most of the issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 13, 2018

@GrahamcOfBorg build grass qgis

@mpickering
Copy link
Contributor Author

QGIS will definitely take too long to compile. GRASS will probably compile within the time limit.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: grass, qgis

Partial log (click to expand)

gzipping man pages under /nix/store/ch0qnkc483v370r5djxg37nr88p6px0j-qgis-2.18.17/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ch0qnkc483v370r5djxg37nr88p6px0j-qgis-2.18.17/lib  /nix/store/ch0qnkc483v370r5djxg37nr88p6px0j-qgis-2.18.17/bin 
patching script interpreter paths in /nix/store/ch0qnkc483v370r5djxg37nr88p6px0j-qgis-2.18.17
/nix/store/ch0qnkc483v370r5djxg37nr88p6px0j-qgis-2.18.17/share/qgis/grass/scripts/db.connect-login.pg.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python"
/nix/store/ch0qnkc483v370r5djxg37nr88p6px0j-qgis-2.18.17/share/qgis/grass/scripts/qgis.v.kernel.rast.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python"
/nix/store/ch0qnkc483v370r5djxg37nr88p6px0j-qgis-2.18.17/share/qgis/grass/scripts/qgis.v.upgrade.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python"
/nix/store/ch0qnkc483v370r5djxg37nr88p6px0j-qgis-2.18.17/share/qgis/grass/scripts/r.external.all.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python"
/nix/store/ch0qnkc483v370r5djxg37nr88p6px0j-qgis-2.18.17/share/qgis/grass/scripts/v.out.ogr.pg.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python"
checking for references to /build in /nix/store/ch0qnkc483v370r5djxg37nr88p6px0j-qgis-2.18.17...

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: grass, qgis

Partial log (click to expand)

2 warnings generated.
[ 49%] Building CXX object src/providers/virtual/CMakeFiles/virtuallayerprovider.dir/qgsvirtuallayerfeatureiterator.cpp.o
[ 49%] Building CXX object src/providers/virtual/CMakeFiles/virtuallayerprovider.dir/qgsvirtuallayerblob.cpp.o
[ 49%] Building CXX object src/providers/virtual/CMakeFiles/virtuallayerprovider.dir/qgsvirtuallayersqlitemodule.cpp.o
[ 49%] Building CXX object src/providers/virtual/CMakeFiles/virtuallayerprovider.dir/qgsvirtuallayersqlitehelper.cpp.o
[ 49%] Building CXX object src/providers/virtual/CMakeFiles/virtuallayerprovider.dir/qgsvirtuallayerqueryparser.cpp.o
[ 50%] Building CXX object src/providers/virtual/CMakeFiles/virtuallayerprovider.dir/qgsvirtuallayersourceselect.cpp.o
[ 50%] Building CXX object src/providers/virtual/CMakeFiles/virtuallayerprovider.dir/qgsembeddedlayerselectdialog.cpp.o
building of '/nix/store/x836lm7mvb5gx8ky4vr2ib64wiz34hvn-qgis-2.18.17.drv' timed out after 1800 seconds
�[31;1merror:�[0m build of '/nix/store/x836lm7mvb5gx8ky4vr2ib64wiz34hvn-qgis-2.18.17.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: grass, qgis

Partial log (click to expand)

               ^~~~
/build/hdf-4.2.13/hdf/src/hfile.h:606:15: error: unknown type name 'int32'
     HDFLIBAPI int32 HCPread
               ^~~~~
/build/hdf-4.2.13/hdf/src/dfimcomp.c:83:9: error: unknown type name 'VOID'
building of '/nix/store/i5jnsjnjf02gn92g3k89z9khb58wg2s4-hdf-4.2.13.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/bj7rrq4w4sdb2as9gc6wcnr60050ds9d-gdal-2.2.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pa1ra1i5spfp8cjy27hjchravzvjiwjd-grass-7.2.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/by53i75bkqxy24ayg6ggl1lz4zlxgci7-qgis-2.18.17.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/by53i75bkqxy24ayg6ggl1lz4zlxgci7-qgis-2.18.17.drv', '/nix/store/pa1ra1i5spfp8cjy27hjchravzvjiwjd-grass-7.2.2.drv' failed

@Mic92 Mic92 merged commit 615599c into NixOS:master Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpickering @Mic92 @GrahamcOfBorg