Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary NoReturn annotation #5945

Merged
merged 1 commit into from Apr 13, 2018
Merged

Remove unnecessary NoReturn annotation #5945

merged 1 commit into from Apr 13, 2018

Conversation

bew
Copy link
Contributor

@bew bew commented Apr 13, 2018

It makes no sense to add it, as almost every method/block can potentially raise.

Note: it was the only place in the stdlib where this annotation is added.

@asterite asterite merged commit 27f8b5d into crystal-lang:master Apr 13, 2018
@RX14 RX14 added this to the Next milestone Apr 13, 2018
@bew bew deleted the remove-unecessary-noreturn branch April 13, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@bcardiff bcardiff bcardiff approved these changes

@wooster0 wooster0 wooster0 approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bew @asterite @bcardiff @wooster0 @RX14