git: add install checks #38924
Closed
git: add install checks #38924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're a hero! |
8 tasks
|
Merged after sorting out conflicts (and re-updating to 2.17.0,haha that history is madness), thanks for putting this together! Here's hoping it helps catch problems with our git package moving forward! |
Thanks @dtzWill !
We are doomed ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the epic failure of reverting three times the update to 2.17.0, I decided to add install checks to git.
This was quite a feat, and also increases the build time significantly.
Please do not merge this before proper testing on MacOS. Only tests are added, so it should be e very low impact PR, but git is quite central to nix{,pkgs}.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)