Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dosage: Fix tests #38921

Merged
merged 1 commit into from Apr 14, 2018
Merged

dosage: Fix tests #38921

merged 1 commit into from Apr 14, 2018

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Apr 13, 2018 •
edited

Motivation for this change

Tests weren't working.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 14, 2018

@GrahamcOfBorg build dosage

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dosage

Partial log (click to expand)


tests/test_comicnames.py .                                               [  3%]
tests/test_dosage.py ..........                                          [ 36%]
tests/test_scraper.py ....                                               [ 50%]
tests/test_singletoninstance.py ...                                      [ 60%]
tests/test_util.py ...........                                           [ 96%]
tests/test_vote.py .                                                     [100%]

========================== 30 passed in 6.46 seconds ===========================
/nix/store/hrwdlrh3b7l3z6fag7b8yn632k8yxj2c-dosage-2018.04.08

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: dosage

Partial log (click to expand)


tests/test_comicnames.py .                                               [  3%]
tests/test_dosage.py ..........                                          [ 36%]
tests/test_scraper.py ....                                               [ 50%]
tests/test_singletoninstance.py ...                                      [ 60%]
tests/test_util.py ...........                                           [ 96%]
tests/test_vote.py .                                                     [100%]

========================== 30 passed in 5.15 seconds ===========================
/nix/store/xwinixfynmvbd7xdma4mrhhkhpg424b1-dosage-2018.04.08

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dosage

Partial log (click to expand)


tests/test_comicnames.py .                                               [  3%]
tests/test_dosage.py ..........                                          [ 36%]
tests/test_scraper.py ....                                               [ 50%]
tests/test_singletoninstance.py ...                                      [ 60%]
tests/test_util.py ...........                                           [ 96%]
tests/test_vote.py .                                                     [100%]

========================== 30 passed in 10.33 seconds ==========================
/nix/store/7y3bn7yyc4krfgf1x9g9s7lylxpjfnzn-dosage-2018.04.08

@Mic92 Mic92 merged commit 958aa81 into NixOS:master Apr 14, 2018
@Moredread Moredread deleted the tests/dosage branch April 14, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @Mic92 @GrahamcOfBorg