Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use basic ipynb template by default for slightly better appearance and behavior #3020

Merged
merged 2 commits into from Apr 15, 2018
Merged

Use basic ipynb template by default for slightly better appearance and behavior #3020

merged 2 commits into from Apr 15, 2018

Conversation

Kwpolska
Copy link
Member

This removes #notebook and #notebook-container from ipynb posts.

h/t @gramster for making me look at nbexport config options in #3019 and noticing this discrepancy.

--- index.html	2018-04-13 19:06:38.000000000 +0200
+++ old.html	2018-04-13 19:04:46.000000000 +0200
@@ -92,7 +92,9 @@
         
 
     </header><div class="e-content entry-content" itemprop="articleBody text">
-    <div>
+    <div tabindex="-1" id="notebook" class="border-box-sizing">
+    <div class="container" id="notebook-container">
+
 <div class="cell border-box-sizing text_cell rendered">
 <div class="prompt input_prompt">
 </div>
@@ -544,7 +546,9 @@
 </div>
 </div>
 </div>
-</div>
+    </div>
+  </div>
+
     </div>
     <aside class="postpromonav"><nav><ul class="pager hidden-print">
 <li class="previous">

@Kwpolska
Use basic ipynb template by default
f86790e 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added the minor label Apr 13, 2018
@Kwpolska Kwpolska added this to the v8.0.0 milestone Apr 13, 2018
@Kwpolska Kwpolska merged commit df80757 into master Apr 15, 2018
@Kwpolska Kwpolska deleted the ipynb-basic-template branch April 15, 2018 14:41
@Kwpolska
Copy link
Member Author

Thanks for reviewing!

PS. You might have forgotten to press merge, and I misinterpreted the commit e-mail. Double brain fart.

@damianavila
Copy link
Member

I need to test this one but seems a reasonable change. Sorry for the delayed feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralsina ralsina ralsina approved these changes

@damianavila damianavila Awaiting requested review from damianavila

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kwpolska @damianavila @ralsina