Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xen-4.8: fix qemu-xen build error in memfd.c #38917

Merged
merged 1 commit into from Apr 14, 2018
Merged

xen-4.8: fix qemu-xen build error in memfd.c #38917

merged 1 commit into from Apr 14, 2018

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Apr 13, 2018 •
edited

Apply qemu/qemu@75e5b70
see also https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg08648.html

cc @eelco @tstrobel @oxij

Motivation for this change

This fixes this hydra failure on my machine

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bendlas
Copy link
Contributor Author

bendlas commented Apr 13, 2018

In the build log there are still a couple of errors, like

...
/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash: /build/xen-4.8.3/tools/../tools/qemu-xen/scripts/tracetool.py: /usr/bin/env: bad interpreter: No such file or directory
/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash: /build/xen-4.8.3/tools/../tools/qemu-xen/scripts/tracetool.py: /usr/bin/env: bad interpreter: No such file or directory
...
make[7]: Entering directory '/build/xen-4.8.3/tools/firmware/etherboot/ipxe/src'
/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash: /bin/echo: No such file or directory

I first followed those leads, but with the patch, the build came through, so I assume those have been there before.

@xeji
Copy link
Contributor

xeji commented Apr 13, 2018

These impurities have been there before but didn't seem to matter.

@Mic92 Mic92 merged commit 81885b4 into NixOS:master Apr 14, 2018
@xeji xeji mentioned this pull request Apr 28, 2018
Merged
8 tasks
@bendlas bendlas deleted the fix-xen branch October 22, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bendlas @xeji @Mic92 @GrahamcOfBorg