Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsibreak: init at 0.12.8 #38340

Merged
merged 1 commit into from Apr 5, 2018
Merged

rsibreak: init at 0.12.8 #38340

merged 1 commit into from Apr 5, 2018

Conversation

vandenoever
Copy link
Contributor

Motivation for this change

A useful application that works well: RSIbreak.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

nlewo
nlewo reviewed Apr 4, 2018
View reviewed changes
pkgs/applications/misc/rsibreak/default.nix Outdated
sha256 = "1qn9xdjx9zzw47jsj7f4nkqmrangfhdgafm2jxm7cm6z6kcvzr28";
};

meta = with lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this attribute at the end of the derivation?
Otherwise, LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

nlewo
nlewo reviewed Apr 5, 2018
View reviewed changes
pkgs/applications/video/mpv/default.nix Outdated
@@ -83,7 +83,7 @@ let
};
in stdenv.mkDerivation rec {
name = "mpv-${version}";
version = "0.27.2";
version = "0.28.2";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sounds like a mistake...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, added a local change by accident. Fixed now.

@nlewo
Copy link
Member

nlewo commented Apr 5, 2018

@GrahamcOfBorg build rsibreak

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rsibreak

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c7pmg2qflvh313k88ayv6i5zwwm9ygan-rsibreak-0.12.8
shrinking /nix/store/c7pmg2qflvh313k88ayv6i5zwwm9ygan-rsibreak-0.12.8/bin/rsibreak
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/c7pmg2qflvh313k88ayv6i5zwwm9ygan-rsibreak-0.12.8/bin
patching script interpreter paths in /nix/store/c7pmg2qflvh313k88ayv6i5zwwm9ygan-rsibreak-0.12.8
checking for references to /tmp/nix-build-rsibreak-0.12.8.drv-0 in /nix/store/c7pmg2qflvh313k88ayv6i5zwwm9ygan-rsibreak-0.12.8...
postPatchMkspecs
postPatchMkspecs

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rsibreak

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g4czskiddws8cdb59i44j3sxdd3fdnf8-rsibreak-0.12.8
shrinking /nix/store/g4czskiddws8cdb59i44j3sxdd3fdnf8-rsibreak-0.12.8/bin/rsibreak
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/g4czskiddws8cdb59i44j3sxdd3fdnf8-rsibreak-0.12.8/bin
patching script interpreter paths in /nix/store/g4czskiddws8cdb59i44j3sxdd3fdnf8-rsibreak-0.12.8
checking for references to /build in /nix/store/g4czskiddws8cdb59i44j3sxdd3fdnf8-rsibreak-0.12.8...
postPatchMkspecs
postPatchMkspecs

@nlewo nlewo merged commit 9049f8a into NixOS:master Apr 5, 2018
@nlewo
Copy link
Member

nlewo commented Apr 5, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vandenoever @nlewo @GrahamcOfBorg