-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort by "update"-column on clicking "add available updates"-button #2392
Conversation
…ates"-button Automatically sort by "Update"-column after clicking "Add available Updates"-button
This seems like something that should be an option. I'm sure some users would find it extremely annoying, I'd be happy for it to be the default behaviour, though. I realise that this would bump up the complexity of the coding significantly, so @DasSkelett, if you'd like some help with that, just say so and I'm sure someone would be happy to make a PR to your branch to handle the option-setting. |
Thanks for your thoughts. So should it be opt-in or opt-out? |
Make it opt-out. |
Added a "more settings" group box and a textbox do disable auto-sort.
Okay, don't know why my upstream pull (only containing a495f43) failed CI... |
It failed and travis posted something about tcp errors so I restarted the job and it passed... sounds like a network issue more than a codeissue. |
Ah thanks :D |
Could you move the "Hide Epochs" button into the new "More Settings" group box? It doesn't really belong in Updates. |
Move "Hide Epochs" checkbox to "More Settings" group box.
Moved it, now looking like this: One more question:
This would solve the annoying Designer Error in VisualStudio and the Settings window would look nicer if Edit: I created a new branch on my fork for my question. |
DasSkellet, can you raise a new PR for the change in controls dependency? I'm not sure what designer error you are getting, as I don't use VisualStudio most of the time. |
Hey, I just thought of a little enhancement, and decided to create the PR myself.
So now, after clicking the "Add all available updates" button, the modlist automatically sorts by "update" column and focuses/selects and scrolls to first row.
I'm not that experienced at programming and furthermore this is my first commit on CKAN and I just copy-pasted together code which seemed to do the right things, after trying to get an overview of the code for some hours :D
Well, it worked after building, so yeah.