Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.03] tdesktop: use wrapGAppsHook #38359

Merged
merged 1 commit into from Apr 5, 2018
Merged

[18.03] tdesktop: use wrapGAppsHook #38359

merged 1 commit into from Apr 5, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Apr 2, 2018

Motivation for this change

Mostly a backport of #37587, telegram-desktop crashes on choose file dialog (which is apparently required for account registration within the app).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tdesktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tdesktop

Partial log (click to expand)

Wrapping program /nix/store/hbhnd8y0czmnzznnmzmvjbbn0yc4ywlj-telegram-desktop-1.2.6/bin/telegram-desktop
shrinking RPATHs of ELF executables and libraries in /nix/store/hbhnd8y0czmnzznnmzmvjbbn0yc4ywlj-telegram-desktop-1.2.6
shrinking /nix/store/hbhnd8y0czmnzznnmzmvjbbn0yc4ywlj-telegram-desktop-1.2.6/bin/.telegram-desktop-wrapped
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hbhnd8y0czmnzznnmzmvjbbn0yc4ywlj-telegram-desktop-1.2.6/bin
patching script interpreter paths in /nix/store/hbhnd8y0czmnzznnmzmvjbbn0yc4ywlj-telegram-desktop-1.2.6
checking for references to /build in /nix/store/hbhnd8y0czmnzznnmzmvjbbn0yc4ywlj-telegram-desktop-1.2.6...
postPatchMkspecs
postPatchMkspecs
/nix/store/hbhnd8y0czmnzznnmzmvjbbn0yc4ywlj-telegram-desktop-1.2.6

@Mic92 Mic92 merged commit c0a0b2d into NixOS:release-18.03 Apr 5, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 5, 2018

Thanks!

@pbogdan
Copy link
Member Author

pbogdan commented Apr 5, 2018

Thank you.

@pbogdan pbogdan deleted the telegram-gapps-hook branch December 3, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @GrahamcOfBorg @Mic92