Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freerdp: 2.0.0-rc1 -> 2.0.0-rc2 #38886

Closed
wants to merge 1 commit into from
Closed

freerdp: 2.0.0-rc1 -> 2.0.0-rc2 #38886

wants to merge 1 commit into from

Conversation

peterhoeg
Copy link
Member

Motivation for this change

rc1 is effectively unusable so we really need rc2. I'm running it here and will merge later today if all OK as well as backport to 18.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg self-assigned this Apr 13, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: freerdp

Partial log (click to expand)

                                 Dload  Upload   Total   Spent    Left  Speed
100   126    0   126    0     0   1235      0 --:--:-- --:--:-- --:--:--  1235
copying path '/nix/store/j8wyhwi347990b3rcd5mf0iqr1ng6jd1-binutils-wrapper-2.30' from 'https://cache.nixos.org'...
copying path '/nix/store/7vqlf4iwmb1s24zyx1nfzyhi3qh0gpmw-gcc-wrapper-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/9vknvj1gnbd2mbci7sw07cy1lgyxxy02-stdenv-linux' from 'https://cache.nixos.org'...
100 6413k    0 6413k    0     0  7653k      0 --:--:-- --:--:-- --:--:-- 7653k
unpacking source archive /build/2.0.0-rc2.tar.gz
fixed-output derivation produced path '/nix/store/4200i7hxjb7m8hqpvj6l8vlk2bm9znx9-source' with sha256 hash '01cm9g4xqihnnc5d2w1zs8gabkv59p7fyjwi1cwpzv6s198xwbfs' instead of the expected hash '0330f5bxbsg3g3bxvmi1kcf9cs28i091l3ql46aqmb7xjdw3yhav'
cannot build derivation '/nix/store/7ck9ppy19fb33qmpgg2f8ia1p8r3id9q-freerdp-2.0.0-rc2.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/7ck9ppy19fb33qmpgg2f8ia1p8r3id9q-freerdp-2.0.0-rc2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: freerdp

Partial log (click to expand)

  95 6151k    0     0  1264k      0
 0:00:05  0:00:
04  0:00:
01 1511k

100 6413k  100 6413k    0     0  1296k      0  0:00:
04  0:00:04 --:--:-- 1545k
unpacking source archive /tmp/nix-build-source.drv-0/2.0.0-rc2.tar.gz
output path ‘/nix/store/b9fszcp5wqmdmhbz25kp7z1igf34cxcs-source’ has r:sha256 hash ‘01cm9g4xqihnnc5d2w1zs8gabkv59p7fyjwi1cwpzv6s198xwbfs’ when ‘0330f5bxbsg3g3bxvmi1kcf9cs28i091l3ql46aqmb7xjdw3yhav’ was expected
cannot build derivation ‘/nix/store/qji639if6qw45vmrbiz6dscjdr1k7kdf-freerdp-2.0.0-rc2.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/qji639if6qw45vmrbiz6dscjdr1k7kdf-freerdp-2.0.0-rc2.drv’ failed

Mic92
Mic92 reviewed Apr 15, 2018
View reviewed changes
pkgs/applications/networking/remote/freerdp/default.nix

src = fetchFromGitHub {
owner = "FreeRDP";
repo = "FreeRDP";
rev = version;
sha256 = "0m28n3mq3ax0j6j3ai4pnlx3shg2ap0md0bxlqkhfv6civ9r11nn";
sha256 = "0330f5bxbsg3g3bxvmi1kcf9cs28i091l3ql46aqmb7xjdw3yhav";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get

fixed-output derivation produced path '/nix/store/4200i7hxjb7m8hqpvj6l8vlk2bm9znx9-source' with sha256 hash '01cm9g4xqihnnc5d2w1zs8gabkv59p7fyjwi1cwpzv6s198xwbfs' instead of the expected hash '0330f5bxbsg3g3bxvmi
1kcf9cs28i091l3ql46aqmb7xjdw3yhav'
cannot build derivation '/nix/store/6dlyxp9ggswfkl006scl399xfcqnzv8c-freerdp-2.0.0-rc2.drv': 1 dependencies couldn't be built

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super strange - I've just tried running nix-prefetch-url -A freerdp.src and it produces the expected hash 0330f5bxbsg3g3bxvmi1kcf9cs28i091l3ql46aqmb7xjdw3yhav. Are you behind a misbehaving proxy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That pull request has the same hash I see: #39077

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the build bots report broken checksums.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When happens if you run nix-prefetch-url -A freerdp.src ?

Copy link
Contributor

@tokudan tokudan Apr 18, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after checking out your PR I get this output:

$ nix-prefetch-url -A freerdp.src
unpacking...
path is '/nix/store/4200i7hxjb7m8hqpvj6l8vlk2bm9znx9-source'
01cm9g4xqihnnc5d2w1zs8gabkv59p7fyjwi1cwpzv6s198xwbfs

Is it possible that freerdp changed their tag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm an idiot. I had an overlay for freerdp because rc1 is broken. Merged in da46950 and will backport too.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: freerdp

Partial log (click to expand)

shrinking /nix/store/gj834xksi4w0pk2aksbidhnn9px0fvd5-gst-plugins-good-1.14.0/lib/gstreamer-1.0/libgstapetag.so
shrinking /nix/store/gj834xksi4w0pk2aksbidhnn9px0fvd5-gst-plugins-good-1.14.0/lib/gstreamer-1.0/libgstalphacolor.so
shrinking /nix/store/gj834xksi4w0pk2aksbidhnn9px0fvd5-gst-plugins-good-1.14.0/lib/gstreamer-1.0/libgstalpha.so
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gj834xksi4w0pk2aksbidhnn9px0fvd5-gst-plugins-good-1.14.0/lib
patching script interpreter paths in /nix/store/gj834xksi4w0pk2aksbidhnn9px0fvd5-gst-plugins-good-1.14.0
checking for references to /build in /nix/store/gj834xksi4w0pk2aksbidhnn9px0fvd5-gst-plugins-good-1.14.0...
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
cannot build derivation '/nix/store/lsrdc0bvjrfccq6pgcb4p6kafwzrswsg-freerdp-2.0.0-rc2.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/lsrdc0bvjrfccq6pgcb4p6kafwzrswsg-freerdp-2.0.0-rc2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: freerdp

Partial log (click to expand)

shrinking /nix/store/k0lm5zyrsrdxrpjdrksjg6xvipm0cqpj-gst-plugins-good-1.14.0/lib/gstreamer-1.0/libgstvideocrop.so
shrinking /nix/store/k0lm5zyrsrdxrpjdrksjg6xvipm0cqpj-gst-plugins-good-1.14.0/lib/gstreamer-1.0/libgstalaw.so
shrinking /nix/store/k0lm5zyrsrdxrpjdrksjg6xvipm0cqpj-gst-plugins-good-1.14.0/lib/gstreamer-1.0/libgstautodetect.so
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/k0lm5zyrsrdxrpjdrksjg6xvipm0cqpj-gst-plugins-good-1.14.0/lib
patching script interpreter paths in /nix/store/k0lm5zyrsrdxrpjdrksjg6xvipm0cqpj-gst-plugins-good-1.14.0
checking for references to /build in /nix/store/k0lm5zyrsrdxrpjdrksjg6xvipm0cqpj-gst-plugins-good-1.14.0...
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
cannot build derivation '/nix/store/slwmqhyl0xqr6slg15isj7f58c7388kp-freerdp-2.0.0-rc2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/slwmqhyl0xqr6slg15isj7f58c7388kp-freerdp-2.0.0-rc2.drv' failed

@Mic92 Mic92 mentioned this pull request Apr 17, 2018
Closed
8 tasks
@peterhoeg peterhoeg closed this Apr 19, 2018
@peterhoeg peterhoeg deleted the u/rdp branch April 19, 2018 02:31
@peterhoeg peterhoeg mentioned this pull request Apr 19, 2018
Merged
8 tasks
@peterhoeg peterhoeg restored the u/rdp branch April 20, 2018 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@tokudan tokudan tokudan left review comments

Assignees

@peterhoeg peterhoeg

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @GrahamcOfBorg @Mic92 @tokudan