Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.apsw: 3.9.2-r1 -> 3.22.0-r1 #38892

Merged
merged 1 commit into from Apr 13, 2018
Merged

pythonPackages.apsw: 3.9.2-r1 -> 3.22.0-r1 #38892

merged 1 commit into from Apr 13, 2018

Conversation

xvapx
Copy link
Contributor

@xvapx xvapx commented Apr 13, 2018

Replaced fetchPypi with fetchFromGitHub because no new version has been uploaded to pypi since 2016, but there are new releases on github.

We need a recent version for new tribler versions to work.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This PR does not fit CONTRIBUTING.md because meta.maintainers is not set.

@xvapx xvapx requested a review from FRidh as a code owner April 13, 2018 08:03
@xvapx xvapx mentioned this pull request Apr 13, 2018
Closed
@dotlambda
Copy link
Member

The website even says

APSW is not available at the Python Package Index

dotlambda
dotlambda requested changes Apr 13, 2018
View reviewed changes
pkgs/development/python-modules/apsw/default.nix Outdated
src = fetchFromGitHub {
owner = "rogerbinns";
repo = "apsw";
rev = "${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rev = version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.apsw python3.pkgs.apsw

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.apsw, python3.pkgs.apsw

Partial log (click to expand)

Ran 85 tests in 123.380s

OK
.....................................................................................
----------------------------------------------------------------------
Ran 85 tests in 125.334s

OK
/nix/store/dzwcb320gx6b0w41qqvh2yvz7v0a8cym-python2.7-apsw-3.22.0-r1
/nix/store/a93bqydibdj9mnib6xk7xsrsls7i9m7b-python3.6-apsw-3.22.0-r1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.apsw, python3.pkgs.apsw

Partial log (click to expand)

.
.
.

----------------------------------------------------------------------
Ran 85 tests in 171.992s

OK
/nix/store/mwdbr25kjp79n4rb3nzxdl27wxb7n18n-python2.7-apsw-3.22.0-r1
/nix/store/71bk04xvph9wbf2b78dfxf254rcgwnyh-python3.6-apsw-3.22.0-r1

@xvapx
pythonPackages.apsw: 3.9.2-r1 -> 3.22.0-r1
a49cb86 
Replaced fetchPypi with fetchFromGitHub because no new version has been uploaded to pypi since 2016, but there are new releases on github
@dotlambda dotlambda merged commit eb76a6a into NixOS:master Apr 13, 2018
@xvapx xvapx deleted the upd/apsw branch June 27, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xvapx @dotlambda @GrahamcOfBorg