Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uplifting #37717 pr to release-18.03 branch #37924

Merged
merged 2 commits into from Mar 27, 2018
Merged

uplifting #37717 pr to release-18.03 branch #37924

merged 2 commits into from Mar 27, 2018

Conversation

garbas
Copy link
Member

@garbas garbas commented Mar 27, 2018

cpages and others added 2 commits March 27, 2018 19:28
@cpages @garbas
qpid-cpp: 0.34 -> 1.37.0
7d492b0
@Ma27 @garbas
qpid-cpp: fix build
f6fb430 
The compilation broke due to the flag `-Werror=int-in-bool-context`
which caused several compilation errors with GCC v7. Disabling this
warning manually with `-Wno-error` in `NIX_CFLAGS_COMPILE` should be
fine.

This package experienced several radical changes as the entire python
build in `$src/management/python` was broken since the given Python
interpreter missed several needed modules (including
`pythonPackages.qpid-python`). As the CMake build tried to invoke the
affected `setup.py` manually and patched the shebangs with `disutil` and
caused non-functional executables, I split the package up into two
parts, the actual `qpid-cpp` lib and the Python module that will be
composed using `buildEnv`.

Furthermore I added myself as maintainer for the package as the diff
became quite huge and we should have more folks available to maintain
this.

See https://hydra.nixos.org/build/71519082/log
See tickets NixOS#36453 and NixOS#31747
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: qpid-cpp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: qpid-cpp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qpid-cpp

Partial log (click to expand)

----------------------------------------------------------------------

Ran 0 tests in 0.000s


OK

building path(s) ‘/nix/store/w47r9wm9p0n2bbkzqw89qxbw93y44b43-qpid-cpp-1.37.0-env’
created 56 symlinks in user environment
/nix/store/w47r9wm9p0n2bbkzqw89qxbw93y44b43-qpid-cpp-1.37.0-env

@garbas garbas merged commit 27ae4ce into NixOS:release-18.03 Mar 27, 2018
@garbas garbas mentioned this pull request Mar 27, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garbas @GrahamcOfBorg @cpages @Ma27