Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.ena: 1.5.0 -> 1.5.2 #37943

Merged
merged 1 commit into from Mar 28, 2018
Merged

linuxPackages.ena: 1.5.0 -> 1.5.2 #37943

merged 1 commit into from Mar 28, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Mar 27, 2018

Motivation for this change

Fixes build with linux 4.15, changelog looks innocent enough https://github.com/amzn/amzn-drivers/blob/ena_linux_1.5.2/kernel/linux/ena/RELEASENOTES.md

Not sure how many folks use stable release in combination with the latest kernel but it might be worth backporting to 18.03 as well (where it doesn't build with linuxPackages_latest as well).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pbogdan
Copy link
Member Author

pbogdan commented Mar 27, 2018

@GrahamcOfBorg build linuxPackages_latest.ena

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: linuxPackages_latest.ena

Partial log (click to expand)

  LD [M]  /tmp/nix-build-ena-1.5.2-4.15.13.drv-0/source/kernel/linux/ena/ena.ko
make[1]: Leaving directory '/nix/store/sw82rcpias2f6pz2znfpcs9763h8gvmc-linux-4.15.13-dev/lib/modules/4.15.13/build'
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/88lxv5kwjzx27l3nq3w3c2w3zimi8lpl-ena-1.5.2-4.15.13
strip is hashed (/nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip)
stripping (with command strip and flags -S) in /nix/store/88lxv5kwjzx27l3nq3w3c2w3zimi8lpl-ena-1.5.2-4.15.13/lib
patching script interpreter paths in /nix/store/88lxv5kwjzx27l3nq3w3c2w3zimi8lpl-ena-1.5.2-4.15.13
checking for references to /tmp/nix-build-ena-1.5.2-4.15.13.drv-0 in /nix/store/88lxv5kwjzx27l3nq3w3c2w3zimi8lpl-ena-1.5.2-4.15.13...
/nix/store/88lxv5kwjzx27l3nq3w3c2w3zimi8lpl-ena-1.5.2-4.15.13

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: linuxPackages_latest.ena

Partial log (click to expand)

  LD [M]  /build/source/kernel/linux/ena/ena.ko
make[1]: Leaving directory '/nix/store/7wakk1ncw0vbyd11nia6x6nk2jcck208-linux-4.15.13-dev/lib/modules/4.15.13/build'
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gdjajwk2si2mb72w0mxdhqmihpaklxbm-ena-1.5.2-4.15.13
strip is hashed (/nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip)
stripping (with command strip and flags -S) in /nix/store/gdjajwk2si2mb72w0mxdhqmihpaklxbm-ena-1.5.2-4.15.13/lib
patching script interpreter paths in /nix/store/gdjajwk2si2mb72w0mxdhqmihpaklxbm-ena-1.5.2-4.15.13
checking for references to /build in /nix/store/gdjajwk2si2mb72w0mxdhqmihpaklxbm-ena-1.5.2-4.15.13...
/nix/store/gdjajwk2si2mb72w0mxdhqmihpaklxbm-ena-1.5.2-4.15.13

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: linuxPackages.ena

Partial log (click to expand)

  LD [M]  /build/source/kernel/linux/ena/ena.ko
make[1]: Leaving directory '/nix/store/ppa9alxarcg75ps2xwpky5x88jc93ncy-linux-4.14.30-dev/lib/modules/4.14.30/build'
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/y7x5wgash3njlss0s4xhdp9c5mv5rbq4-ena-1.5.2-4.14.30
strip is hashed (/nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip)
stripping (with command strip and flags -S) in /nix/store/y7x5wgash3njlss0s4xhdp9c5mv5rbq4-ena-1.5.2-4.14.30/lib
patching script interpreter paths in /nix/store/y7x5wgash3njlss0s4xhdp9c5mv5rbq4-ena-1.5.2-4.14.30
checking for references to /build in /nix/store/y7x5wgash3njlss0s4xhdp9c5mv5rbq4-ena-1.5.2-4.14.30...
/nix/store/y7x5wgash3njlss0s4xhdp9c5mv5rbq4-ena-1.5.2-4.14.30

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: linuxPackages.ena

Partial log (click to expand)

  LD [M]  /build/source/kernel/linux/ena/ena.ko
make[1]: Leaving directory '/nix/store/9qysyw54mi09b17dz12wy7b08fxhyr3w-linux-4.14.30-dev/lib/modules/4.14.30/build'
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/b5lhj3qshxv66i1mb18vl9ynyzn0afx8-ena-1.5.2-4.14.30
strip is hashed (/nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip)
stripping (with command strip and flags -S) in /nix/store/b5lhj3qshxv66i1mb18vl9ynyzn0afx8-ena-1.5.2-4.14.30/lib
patching script interpreter paths in /nix/store/b5lhj3qshxv66i1mb18vl9ynyzn0afx8-ena-1.5.2-4.14.30
checking for references to /build in /nix/store/b5lhj3qshxv66i1mb18vl9ynyzn0afx8-ena-1.5.2-4.14.30...
/nix/store/b5lhj3qshxv66i1mb18vl9ynyzn0afx8-ena-1.5.2-4.14.30

@Mic92 Mic92 merged commit dfff83a into NixOS:master Mar 28, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 28, 2018

backport:
[detached HEAD 51c49db] linuxPackages.ena: 1.5.0 -> 1.5.2
Author: Piotr Bogdan ppbogdan@gmail.com
Date: Tue Mar 27 22:28:58 2018 +0100
1 file changed, 2 insertions(+), 2 deletions(-)

@pbogdan pbogdan deleted the ena-update branch December 3, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @GrahamcOfBorg @Mic92