Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slim: musl patch #37934

Merged
merged 1 commit into from Mar 27, 2018
Merged

slim: musl patch #37934

merged 1 commit into from Mar 27, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 27, 2018

Add missing include on libgen.h, fix w/musl.

I don't think slim is still maintained,
so unlikely to see this upstreamed.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: slim

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: slim

Partial log (click to expand)

these paths will be fetched (0.24 MiB download, 0.45 MiB unpacked):
  /nix/store/s8mv5q34zgyk35ijb9jd76wd45zknqnj-slim-1.3.6
copying path '/nix/store/s8mv5q34zgyk35ijb9jd76wd45zknqnj-slim-1.3.6' from 'https://cache.nixos.org'...
/nix/store/s8mv5q34zgyk35ijb9jd76wd45zknqnj-slim-1.3.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: slim

Partial log (click to expand)

these paths will be fetched (0.32 MiB download, 0.97 MiB unpacked):
  /nix/store/0j93g7kphfs4lqlsjw71khky8kwm95ns-slim-1.3.6
  /nix/store/0kpl8l3fix5vcin3zcxvxkd02g81mhh8-libpng-1.2.57
copying path '/nix/store/0kpl8l3fix5vcin3zcxvxkd02g81mhh8-libpng-1.2.57' from 'https://cache.nixos.org'...
copying path '/nix/store/0j93g7kphfs4lqlsjw71khky8kwm95ns-slim-1.3.6' from 'https://cache.nixos.org'...
/nix/store/0j93g7kphfs4lqlsjw71khky8kwm95ns-slim-1.3.6

@dtzWill dtzWill merged commit cfd79b4 into NixOS:master Mar 27, 2018
@dtzWill dtzWill deleted the fix/slim-musl branch March 27, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg