Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flow: 0.66.0 -> 0.68.0 #37936

Merged
merged 2 commits into from Mar 27, 2018
Merged

flow: 0.66.0 -> 0.68.0 #37936

merged 2 commits into from Mar 27, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Mar 27, 2018

Motivation for this change

See #37729: updating flow needs new package lwt_ppx.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vbgl vbgl mentioned this pull request Mar 27, 2018
Closed
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: flow

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flow

Partial log (click to expand)

cp _build/src/flow.native bin/flow
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2v8x9kv5rjcbnq29wg3dk9bl5h6pi7ah-flow-0.68.0
shrinking /nix/store/2v8x9kv5rjcbnq29wg3dk9bl5h6pi7ah-flow-0.68.0/bin/flow
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2v8x9kv5rjcbnq29wg3dk9bl5h6pi7ah-flow-0.68.0/bin
patching script interpreter paths in /nix/store/2v8x9kv5rjcbnq29wg3dk9bl5h6pi7ah-flow-0.68.0
checking for references to /build in /nix/store/2v8x9kv5rjcbnq29wg3dk9bl5h6pi7ah-flow-0.68.0...
/nix/store/2v8x9kv5rjcbnq29wg3dk9bl5h6pi7ah-flow-0.68.0

@frontsideair
Copy link
Contributor

Built and tested on NixOS, works perfectly. Awesome work, thanks!

@Mic92 Mic92 merged commit 97fc985 into NixOS:master Mar 27, 2018
@vbgl vbgl deleted the flow-0.68 branch March 28, 2018 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @GrahamcOfBorg @frontsideair @Mic92